chore: support prek #67
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| for call in handle.writelines.call_args_list: | ||
| written_lines.extend(call[0][0]) | ||
|
|
||
| written_content = "".join(written_lines) |
There was a problem hiding this comment.
Test uses unnecessarily complex assertion pattern
Low Severity
The new test manually iterates over call_args_list to collect written lines and then joins them for comparison. This is unnecessarily complex when the same file already has an established simpler pattern at line 107: mock_file.open().writelines.assert_called_once_with(expected.splitlines(keepends=True)). The new test could use mock_path.open().writelines.assert_called_once_with(expected_content.splitlines(keepends=True)) for consistency and simplicity.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 97.14% 96.57% -0.58%
==========================================
Files 12 12
Lines 701 701
Branches 63 63
==========================================
- Hits 681 677 -4
- Misses 18 20 +2
- Partials 2 4 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
1 participant
Doc & tests update only.
Note
Docs/tests for
prekconfig support; CI matrix updatesprekconfig support (preserveprek-specific keys) and allowpre-commit-config-fileto be.pre-commit-config.yml; update supported versions to Poetry 2.3+ and PDM 2.26+.test_prek_config_supportto ensure updating repo versions preservesprek-specific keys/structure.hishel<1.0pins for py312 with specific PDM versions, update GH env matrix accordingly..mise.tomlPDM to 2.26.Written by Cursor Bugbot for commit 32c01cb. This will update automatically on new commits. Configure here.