Used utility functions to move file functionality to file.py#112
Open
SandeshNarayan wants to merge 6 commits intoGabeGiro:mainfrom
Open
Used utility functions to move file functionality to file.py#112SandeshNarayan wants to merge 6 commits intoGabeGiro:mainfrom
SandeshNarayan wants to merge 6 commits intoGabeGiro:mainfrom
Conversation
GabeGiro
requested changes
Feb 8, 2025
Owner
GabeGiro
left a comment
GabeGiro
left a comment
There was a problem hiding this comment.
Good effort!
I added few comments and please follow the code style of the project for consistency, meaning capture_screenshot should be captureScreenshot
GabeGiro
requested changes
Feb 9, 2025
utils/file.py
Outdated
|
|
||
| import utils.logger as logger | ||
| from utils.logger import MessageTypes | ||
| from selenium.webdriver.remote.webdriver import WebDriver |
Owner
There was a problem hiding this comment.
check other files to see how the webdriver is imported
utils/file.py
Outdated
| logger.logDebugMessage("Error in writeResults", logger.MessageTypes.ERROR, e) | ||
|
|
||
|
|
||
| def createDirectory(path : str): |
Owner
There was a problem hiding this comment.
Again, introducing code style inconsistency with spacing. Check other functions around the code and you'll understand
Author
There was a problem hiding this comment.
Thank you for pointing them out, really appreciate your review. I will make sure to not repeat these mistakes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces utility functions to improve code reuse and maintainability. The changes include:
🔹 Changes Made: