chore(ci): skip enrichment-metrics + mapping-count comments on doc-only PRs#369
Merged
Merged
Conversation
The enrichment-metrics and mapping-count-regression jobs in validate.yml post sticky comments via github-actions[bot] on every PR. For PRs that don't change registry / build output (the v3.4.0 audit-doc series, CHANGELOG-only PRs, LICENSES updates), both jobs emit identical numbers each run — and each comment update triggers a notification email to the PR author for zero signal. Add a `changes` job using dorny/paths-filter@v3 that detects whether a PR touches source-affecting paths (data/, scripts/, CheckID.psd1, CheckID.psm1, .github/workflows/). Gate the two noisy jobs via `needs: changes` + `if: needs.changes.outputs.source == 'true'`. Behavior: - Source PRs (registry, build script, module changes): full validation + both sticky comments — unchanged from today - Doc-only PRs (audit catalogs, CHANGELOG entries, LICENSES, tools/ README): Pester + schema validation still run; the two noisy comment-posting jobs skip — silent on the PR thread Other validate.yml jobs (lint, validate-data, data-quality, test, module-test, python-validate) run on all PRs unchanged. The fix is narrowly scoped to the email-noise sources. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Framework mapping count delta
Result: ✓ PASS — no framework mapping regressions detected. |
Content enrichment populationOverall (1105 checks): rationale 26.3% (291/1105) • impact 26.3% (291/1105) • references 26.3% (291/1105)
Informational only — does not gate the build. The hard release-gate for Critical/High enrichment lives in #281 (v3.2.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Silences the email-noise source you flagged:
github-actions[bot]was posting/updating two sticky comments (enrichment-metrics+mapping-count-regression) on every PR, including the v3.4.0 audit-doc series. Both emitted identical numbers and emailed you for zero signal.Root cause
Both jobs in
.github/workflows/validate.ymlwere gated only byif: github.event_name == 'pull_request'. Doc-only PRs trigger them anyway. Each sticky-comment update is a notification event → email to the PR author.Fix
Add a
changesjob usingdorny/paths-filter@v3that detects source-affecting paths (data/**,scripts/**,CheckID.psd1,CheckID.psm1,.github/workflows/**). Gate the two noisy jobs via:Behavior matrix
Other validate.yml jobs (lint, validate-data, data-quality, test, module-test, python-validate) are unchanged.
Files
.github/workflows/validate.yml— addschangesjob + 2-line gating on the two noisy jobs (32 lines)CHANGELOG.md—[Unreleased]/ Changed entryTest plan
.github/workflows/**so thechangesjob will reportsource = true→ full validation runs (correct: workflow changes need to be validated)Why now
Email noise from the v3.4.0 audit-doc series (12 PRs in two days, each emitting both comments multiple times during CI) is a real friction. Doing the structural fix now prevents it from continuing on the remaining audits (#335, #336) and any future doc-only work.
🤖 Generated with Claude Code