Sets default symbol visibility to hidden. Resolves #74#75
Open
jonesmz wants to merge 1 commit intoGameFoundry:masterfrom
Open
Sets default symbol visibility to hidden. Resolves #74#75jonesmz wants to merge 1 commit intoGameFoundry:masterfrom
jonesmz wants to merge 1 commit intoGameFoundry:masterfrom
Conversation
Member
|
This fails on Windows because the thread-local stuff isn't allowed to be dll exported: |
Contributor
Author
|
Hrmm, so the difficulty here is that with gcc, unless I export the entire class, it won't link. Apparently they don't support exporting individual member functions. Would you be OK with a conditional compile? Export the whole class with gcc, export only the functions with msvc ? |
Member
|
Yep, that sounds fine. |
jonesmz
force-pushed
the
visibility_hidden
branch
5 times, most recently
from
14ab0d0 to
5323443
Compare
jonesmz
force-pushed
the
visibility_hidden
branch
2 times, most recently
from
073d053 to
aea7c1d
Compare
jonesmz
force-pushed
the
visibility_hidden
branch
2 times, most recently
from
c03d4bb to
11e1ee4
Compare
Contributor
Author
|
Sorry for the long delay on this issue. Busy with other stuff shrug. Still planning to provide a patch as described. |
jonesmz
force-pushed
the
visibility_hidden
branch
from
11e1ee4 to
f2d1ad6
Compare
jonesmz
force-pushed
the
visibility_hidden
branch
from
f2d1ad6 to
840548a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.