fix: remove chmod when attempting to write to file#1
Draft
fix: remove chmod when attempting to write to file#1
Conversation
* fix(docs): warn about exposed container ports
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
GandalfDG
force-pushed
the
group_permission
branch
from
a8fdc25 to
e9549b1
Compare
Owner
Author
|
Got around to making this work, though it took figuring out that the electron/configs are in yet another separate config file from the graph's config.edn and the global config.edn. Should this be added as an option in the settings UI (probably on the advanced page?) |
fix: dev warnings from react about missing keys Fix logseq#9872
[why]
Sorting the keys gives the advantage of having strings with same context
together making it easier to have consistency on translations.
[how]
1. Having a .edn file execute:
grep ":" src/resources/dicts/es.edn | grep -v "/" | sort > single_keys
grep ":" src/resources/dicts/es.edn | grep "/" | sort > hierarchical_keys
2. Both files are sorted, now manually merge them into sorted_file. I
decided to left turial keys on top, then single_keys and finally
hierarchical_keys at the end. Check the braces.
3. Execute this script:
#!/bin/bash
while IFS= read -r line; do
if [[ "$line" == *\"* ]]; then
first_quote_index=$(expr index "$line" \")
content_after_quote="${line:$first_quote_index}"
content_before_quote="${line:0:$first_quote_index-1}"
spaces=$(printf '%*s' $((52 - ${#content_before_quote})))
echo "$content_before_quote$spaces\"$content_after_quote"
else
echo "$line"
fi
done <sorted_file >formatted_file
4. Replace the .edn file with the resultant formated_file. Now all
strings start at column 53.
* Update Norwegian translation * Update two strings * Update Norwegian translation
* hide window until theme is loaded * show window on db-restored * move manage call to handle maximized state * hook on theme load
* enhance(api): add page to recent for route api * enhance(api): support open block in right sidebar with entity id
This reverts commit 12642f5.
* run use-effect once
…imestamp (addresses logseq#9920) (logseq#9930) * youtube.cljs: allow for single-digit minutes and seconds in youtube-timestamp (addresses logseq#9920) * youtube.cljs: parse "<number>:<number>" as MM:SS to be consistent with the UI display *NOTE that with this commit, we essentially pass util/safe-parse-int a value we do not say it can take (although it works): nil. This will be fixed in a subsequent commit. * youtube.cljs: remove unreachable branches from cond in parse-timestamp * frontend/util.cljc: update safe-parse-int to accept nil as well. TODO: need help fixing malli schema! * fix: parse timestamp --------- Co-authored-by: charlie <xyhp915@qq.com>
andelf
force-pushed
the
group_permission
branch
from
ea5e0d4 to
276372a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a file doesn't give its owner write permission, it may be for a good reason. Also, if the file isn't writable because the user isn't the owner of the file, the
chmodwill fail.This was causing issues in the case where a user has permission to write to a file because they belong to the group that owns the file, but aren't the file's owning user.