PHP 8.5 - Fix SoapClient doRequest#288
Open
Karting06 wants to merge 2 commits intoGarethp:masterfrom
Open
Conversation
Owner
|
@Karting06 Thanks for this! Since it's a fix specifically for PHP 8.5, would you mind adding PHP 8.5 to the versions matrix of in the Github Flow so that the automated tests verify it working on that version? Then I'm more than happy to accept and release this |
Author
|
@Garethp I think that I added it correctly? |
Owner
|
That looks good to me, thanks! I'll merge and release it later today |
|
@Garethp Can you take a look at this? (without this php8.5 upgrade is not possible) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
First of all thanks for this great project.
After upgrading to PHP 8.5, I couldn't create a calendar event.
I noticed that PHP 8.5 added a breaking change for
__doRequestinSOAPClient(see this issue). I solved it by adding the new parameter.It seems to also work with PHP 8.4.