fix: suppress stack trace exposure in worker status page#17
Merged
Conversation
CodeQL alert #2: raw exception message from heartbeat failures was rendered in the worker HTML status page, potentially leaking internal details (file paths, hostnames, etc.) to external users. Replace str(exc) with a generic "connection failed" message for display; full details remain in server logs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CodeQL alert #2 — CWE-209/CWE-497 stack trace information exposure.
The raw exception message from failed heartbeats (
str(exc)) was stored in_last_errorand rendered directly in the worker HTML status page. This could leak internal implementation details (file paths, hostnames, connection strings) to anyone viewing the worker status page.Change
Replace
_last_error = str(exc)with_last_error = "connection failed". Full exception details remain in server logs vialogger.warning().Test plan
Summary by CodeRabbit