Skip to content

418 update to typescript 5 & update @vue/tsconfig#435

Draft
vin-ni wants to merge 5 commits intomainfrom
418-update-to-typescript-5
Draft

418 update to typescript 5 & update @vue/tsconfig#435
vin-ni wants to merge 5 commits intomainfrom
418-update-to-typescript-5

Conversation

@vin-ni
Copy link
Member

@vin-ni vin-ni commented May 30, 2023

  1. Updated the frontends to typescript 5
  2. Updated @vue/tsconfig to fix the importsNotUsedAsValues bug
  3. Updated typescript configs based on new @vue/tsconfig routes
  4. Fixed element-plus import / compiler settings with info from [TypeScript] [message, message-box] when tsconfig.json set moduleResolution to nodenext or bundler, ElMessage can not be imported. element-plus/element-plus#11818

@vin-ni vin-ni linked an issue May 30, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented May 30, 2023

File Coverage
All files 82%
gencaster/distributor.py 69%
gencaster/schema.py 70%
gencaster/urls.py 77%
osc_server/models.py 91%
osc_server/server.py 55%
story_graph/engine.py 72%
story_graph/markdown_parser.py 85%
story_graph/models.py 98%
story_graph/types.py 99%
stream/models.py 91%
stream/types.py 98%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 1b623c4

@vin-ni vin-ni requested a review from capital-G May 30, 2023 13:40
Copy link
Member

@capital-G capital-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not too sure that node is the proper resolution method when reading the changelog of ts5.

It seems node is somehow deprecated and should be used for comparability if one writes a library.

"extends": "./tsconfig.app.json",
"exclude": [],
"compilerOptions": {
"moduleResolution": "node",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Citing https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#moduleresolution-bundler

If you are using a modern bundler like Vite, esbuild, swc, Webpack, Parcel, and others that implement a hybrid lookup strategy, the new bundler option should be a good fit for you.

As we are using Vite we should maybe use bundler? :) But I don't understand too much of it I must admit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just readt the referenced issue - this seems a bug in ElementPlus, so maybe block the upgrade to TS5 until they have EP fixed their bug for TS5? Or is it necessary to upgrade to TS5? Switching to node resolution seems like a hack to me if TS advises to use bundler, especially since node seems somehow deprecated in favour of nodenext?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put it on hold then

@vin-ni vin-ni marked this pull request as draft May 30, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to typescript 5

2 participants