418 update to typescript 5 & update @vue/tsconfig#435
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1b623c4 |
capital-G
left a comment
There was a problem hiding this comment.
I am not too sure that node is the proper resolution method when reading the changelog of ts5.
It seems node is somehow deprecated and should be used for comparability if one writes a library.
| "extends": "./tsconfig.app.json", | ||
| "exclude": [], | ||
| "compilerOptions": { | ||
| "moduleResolution": "node", |
There was a problem hiding this comment.
Citing https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#moduleresolution-bundler
If you are using a modern bundler like Vite, esbuild, swc, Webpack, Parcel, and others that implement a hybrid lookup strategy, the new bundler option should be a good fit for you.
As we are using Vite we should maybe use bundler? :) But I don't understand too much of it I must admit.
There was a problem hiding this comment.
Sorry, just readt the referenced issue - this seems a bug in ElementPlus, so maybe block the upgrade to TS5 until they have EP fixed their bug for TS5? Or is it necessary to upgrade to TS5? Switching to node resolution seems like a hack to me if TS advises to use bundler, especially since node seems somehow deprecated in favour of nodenext?
There was a problem hiding this comment.
Let's put it on hold then
typescript 5@vue/tsconfigto fix theimportsNotUsedAsValuesbug@vue/tsconfigroutes