Skip to content

Clarify NET10_0_OR_GREATER conditional compilation for DrivelutionMiddleware#149

Closed
Copilot wants to merge 1 commit intoremovefrom
copilot/sub-pr-148
Closed

Clarify NET10_0_OR_GREATER conditional compilation for DrivelutionMiddleware#149
Copilot wants to merge 1 commit intoremovefrom
copilot/sub-pr-148

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

No code changes were made. This PR clarifies that the #if NET10_0_OR_GREATER directive in DrivelutionMiddleware.cs is necessary for multi-targeting support.

Context:

  • GeneralUpdate.Core targets both netstandard2.0 and net10.0
  • GeneralUpdate.Drivelution source files are conditionally linked only when $(TargetFramework) == 'net10.0' (lines 97-129 in GeneralUpdate.Core.csproj)
  • Removing the conditional directive would cause compilation errors for netstandard2.0 builds where the GeneralUpdate.Drivelution namespace is unavailable

The conditional compilation ensures DrivelutionMiddleware is only available on .NET 10.0+ where driver update functionality is supported.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Feb 12, 2026
Copilot AI changed the title [WIP] Remove SetFieldMappings Clarify NET10_0_OR_GREATER conditional compilation for DrivelutionMiddleware Feb 12, 2026
Copilot AI requested a review from JusterZhu February 12, 2026 10:22
@JusterZhu JusterZhu closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants