Skip to content

Update NuGet publish workflow for current component set and .NET 10 support#151

Merged
JusterZhu merged 5 commits intomasterfrom
copilot/modify-publish-nuget-workflow
Feb 12, 2026
Merged

Update NuGet publish workflow for current component set and .NET 10 support#151
JusterZhu merged 5 commits intomasterfrom
copilot/modify-publish-nuget-workflow

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

The workflow was packaging outdated components and using an incompatible .NET SDK version. Updated to align with current repository structure and support all target frameworks.

Changes

  • Updated component list to match current packages:

    • Added: GeneralUpdate.Drivelution, GeneralUpdate.Extension
    • Retained: GeneralUpdate.Bowl, GeneralUpdate.ClientCore, GeneralUpdate.Common, GeneralUpdate.Core, GeneralUpdate.Differential
  • Updated .NET SDK version from 9.0.x to 10.0.x:

    • Required to build GeneralUpdate.Drivelution which targets net10.0
    • Backward compatible with all other components targeting netstandard2.0

The workflow uses caller-provided version input (${{ github.event.inputs.version }}) for unified versioning across all packages via -p:Version and -p:PackageVersion flags.

Original prompt

This section details on the original issue you should resolve

<issue_title>Modify the workflow</issue_title>
<issue_description>Please modify the 'Publish NuGet to releases' workflow to adapt to the current components: GeneralUpdate.Bowl, GeneralUpdate.ClientCore, GeneralUpdate.Core, GeneralUpdate.Differential, GeneralUpdate.Drivelution, and GeneralUpdate.Extension. Unify the release process to use the NuGet version number input by the caller and publish the NuGet packages accordingly.</issue_description>

<agent_instructions>充分理解issue和代码上下文。</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 12, 2026 11:00
Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
Copilot AI changed the title [WIP] Modify the workflow to adapt NuGet publishing Update NuGet publish workflow for current component set Feb 12, 2026
Copilot AI requested a review from JusterZhu February 12, 2026 11:02
$projects = @(
"GeneralUpdate.Bowl",
"GeneralUpdate.ClientCore",
"GeneralUpdate.Common",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GeneralUpdate.Common需要加上

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot check for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added GeneralUpdate.Common back to the component list in commit 591c8bd.

Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
@JusterZhu
Copy link
Collaborator

@copilot Don't we need to modify the .NET version in the workflow? GeneralUpdate.Drivelution uses .NET 10.

Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot Don't we need to modify the .NET version in the workflow? GeneralUpdate.Drivelution uses .NET 10.

Updated the workflow to use .NET 10.0.x in commit 289aaf3 to support GeneralUpdate.Drivelution which targets net10.0. The .NET 10 SDK is backward compatible and can build all other components targeting netstandard2.0.

Copilot AI changed the title Update NuGet publish workflow for current component set Update NuGet publish workflow for current component set and .NET 10 support Feb 12, 2026
@JusterZhu
Copy link
Collaborator

@copilot Is the current workflow ready for release now?

Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot Is the current workflow ready for release now?

Yes, the workflow is ready for release. It includes:

✅ All 7 required components (Bowl, ClientCore, Common, Core, Differential, Drivelution, Extension)
✅ .NET 10.0.x SDK for Drivelution support (backward compatible with other components)
✅ Unified versioning using caller input via ${{ github.event.inputs.version }}
✅ Proper build order (restore → build → pack with --no-build)
✅ GitHub Release creation with NuGet package upload

The workflow has been validated with successful restore and build tests.

@JusterZhu JusterZhu marked this pull request as ready for review February 12, 2026 11:14
Copilot AI review requested due to automatic review settings February 12, 2026 11:14
@JusterZhu JusterZhu merged commit b4f848d into master Feb 12, 2026
2 checks passed
@JusterZhu JusterZhu deleted the copilot/modify-publish-nuget-workflow branch February 12, 2026 11:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the “Publish NuGet to releases” GitHub Actions workflow to package the current set of GeneralUpdate components and build with a .NET SDK that supports net10.0 targets.

Changes:

  • Bumped actions/setup-dotnet from 9.0.x to 10.0.x to support GeneralUpdate.Drivelution (net10.0).
  • Updated the packed project list to include GeneralUpdate.Drivelution and GeneralUpdate.Extension.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +38 to 42
"GeneralUpdate.Extension"
)

foreach ($project in $projects) {
dotnet pack ./src/c#/$project/$project.csproj `
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shell: pwsh means # starts a comment in PowerShell. The paths ./src/c#/... will be parsed as ./src/c with the remainder treated as a comment, which will break dotnet pack (and similarly the earlier restore/build steps). Quote or escape the c# paths (e.g., wrap in quotes or use an escaped #) so PowerShell passes the correct file path to dotnet.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify the workflow

2 participants