Conversation
Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
| $projects = @( | ||
| "GeneralUpdate.Bowl", | ||
| "GeneralUpdate.ClientCore", | ||
| "GeneralUpdate.Common", |
Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
|
@copilot Don't we need to modify the .NET version in the workflow? GeneralUpdate.Drivelution uses .NET 10. |
Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
Updated the workflow to use .NET 10.0.x in commit 289aaf3 to support GeneralUpdate.Drivelution which targets net10.0. The .NET 10 SDK is backward compatible and can build all other components targeting netstandard2.0. |
|
@copilot Is the current workflow ready for release now? |
Yes, the workflow is ready for release. It includes: ✅ All 7 required components (Bowl, ClientCore, Common, Core, Differential, Drivelution, Extension) The workflow has been validated with successful restore and build tests. |
There was a problem hiding this comment.
Pull request overview
Updates the “Publish NuGet to releases” GitHub Actions workflow to package the current set of GeneralUpdate components and build with a .NET SDK that supports net10.0 targets.
Changes:
- Bumped
actions/setup-dotnetfrom9.0.xto10.0.xto supportGeneralUpdate.Drivelution(net10.0). - Updated the packed project list to include
GeneralUpdate.DrivelutionandGeneralUpdate.Extension.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "GeneralUpdate.Extension" | ||
| ) | ||
|
|
||
| foreach ($project in $projects) { | ||
| dotnet pack ./src/c#/$project/$project.csproj ` |
There was a problem hiding this comment.
shell: pwsh means # starts a comment in PowerShell. The paths ./src/c#/... will be parsed as ./src/c with the remainder treated as a comment, which will break dotnet pack (and similarly the earlier restore/build steps). Quote or escape the c# paths (e.g., wrap in quotes or use an escaped #) so PowerShell passes the correct file path to dotnet.
The workflow was packaging outdated components and using an incompatible .NET SDK version. Updated to align with current repository structure and support all target frameworks.
Changes
Updated component list to match current packages:
GeneralUpdate.Drivelution,GeneralUpdate.ExtensionGeneralUpdate.Bowl,GeneralUpdate.ClientCore,GeneralUpdate.Common,GeneralUpdate.Core,GeneralUpdate.DifferentialUpdated .NET SDK version from 9.0.x to 10.0.x:
GeneralUpdate.Drivelutionwhich targets net10.0The workflow uses caller-provided version input (
${{ github.event.inputs.version }}) for unified versioning across all packages via-p:Versionand-p:PackageVersionflags.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.