Skip to content

Fix COM initialization crashes on newer Windows builds #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix COM initialization crashes on newer Windows builds #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Generals/Code/GameEngine/Source/Common/GameEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,20 @@ GameEngine::GameEngine( void )
m_quitting = FALSE;
m_isActive = FALSE;

_Module.Init(NULL, ApplicationHInstance, NULL);
// TheSuperHackers @bugfix sentry 11/01/2026
// Wrap COM module initialization in try-catch to handle Windows compatibility issues.
// On some newer Windows builds (e.g., 10.0.26200), InputRedirectionAdapter::Register
// can trigger fatal breakpoint exceptions during COM initialization.
try
{
_Module.Init(NULL, ApplicationHInstance, NULL);
}
catch (...)
{
// Silently handle COM initialization failures to prevent crashes on incompatible systems.
// The application can still function without full COM support.
DEBUG_LOG(("COM module initialization failed, continuing without full COM support."));
}
}

//-------------------------------------------------------------------------------------------------
Expand Down
15 changes: 14 additions & 1 deletion GeneralsMD/Code/GameEngine/Source/Common/GameEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,20 @@ GameEngine::GameEngine( void )
m_quitting = FALSE;
m_isActive = FALSE;

_Module.Init(NULL, ApplicationHInstance, NULL);
// TheSuperHackers @bugfix sentry 11/01/2026
// Wrap COM module initialization in try-catch to handle Windows compatibility issues.
// On some newer Windows builds (e.g., 10.0.26200), InputRedirectionAdapter::Register
// can trigger fatal breakpoint exceptions during COM initialization.
try
{
_Module.Init(NULL, ApplicationHInstance, NULL);
}
catch (...)
{
// Silently handle COM initialization failures to prevent crashes on incompatible systems.
// The application can still function without full COM support.
DEBUG_LOG(("COM module initialization failed, continuing without full COM support."));
}
}

//-------------------------------------------------------------------------------------------------
Expand Down
Loading