Skip to content

Conversation

@seer-by-sentry
Copy link

@seer-by-sentry seer-by-sentry bot commented Feb 1, 2026

Fixes CLIENT-2SF. The issue was that: Worker thread's std::function callback implicitly captured a dangling this pointer from a deallocated NGMP_OnlineServicesManager instance, causing an access violation on invocation.

  • Introduced an atomic flag m_bShuttingDown to NGMP_OnlineServicesManager to indicate shutdown status.
  • Modified asynchronous callbacks in GetOnlineServiceConfig, CheckVersion, and DownloadPatcherFile to safely access NGMP_OnlineServicesManager member variables, preventing potential crashes during shutdown.
  • Prevented the creation of new screenshot processing threads if NGMP_OnlineServicesManager is shutting down.
  • Ensured all active screenshot threads are joined and completed during NGMP_OnlineServicesManager::Shutdown before proceeding with other cleanup.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 9520320

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants