Improve OnlineServices shutdown safety #312
Open
+143
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CLIENT-2SF. The issue was that: Worker thread's
std::functioncallback implicitly captured a danglingthispointer from a deallocatedNGMP_OnlineServicesManagerinstance, causing an access violation on invocation.m_bShuttingDowntoNGMP_OnlineServicesManagerto indicate shutdown status.GetOnlineServiceConfig,CheckVersion, andDownloadPatcherFileto safely accessNGMP_OnlineServicesManagermember variables, preventing potential crashes during shutdown.NGMP_OnlineServicesManageris shutting down.NGMP_OnlineServicesManager::Shutdownbefore proceeding with other cleanup.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 9520320
Not quite right? Click here to continue debugging with Seer.