167 seedmock data fixes improvements#171
Merged
Merged
Conversation
bamarler
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #167
What changed:
Brief summary of the change (2-3 sentences max).
Added a female athlete (Olga Almazova) to seed data and fixed the 400m hurdle mock data generator. The fixed generator produces strictly alternating foot contacts and correctly positioned hurdle times.
Why:
What problem this solves or requirement it addresses.
The seed data only had male athletes, and the existing hurdle_400m.csv had two bugs visible in the visualizations, both feet registering ground contact simultaneously on every stride.
Technical decisions worth noting:
Any non-obvious choices and their rationale.
Screenshots are not working on my computer for some reason.
Screenshot
Notes