Checks genomicsdb_query output directory and retry once with a new genomicsdb instance when azure access tokens expire#81
Merged
nalinigans merged 7 commits intodevelopfrom Feb 18, 2025
Merged
Conversation
added 3 commits
February 13, 2025 11:23
nalinigans
changed the title
mlathara
reviewed
Feb 15, 2025
| writer = None | ||
| logging.info(f"Processed {msg}") | ||
| return 0 | ||
| except Exception as e: |
Member
There was a problem hiding this comment.
Can we check for a specific exception here, or even check the exception message to only target the signature for what we think is expired tokens?
Member
Author
There was a problem hiding this comment.
Most of the time we see a GenomicsDBIteratorException. But, we cannot be really sure.
| allow_retry = False | ||
| try: | ||
| if not gdb.workspace_exists(export_config.workspace): | ||
| logging.info(f"Retrying query with a new instance of gdb for {msg}...") |
Member
There was a problem hiding this comment.
Could you explain what we're trying to do with this check?
Member
Author
There was a problem hiding this comment.
I m trying to check if the gdb is functional. If it is, it is probably not an expired token, I will document that better in the code. And maybe improve the logging message. Comments?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional checks for genomicsdb_query when output's parent directory does not exist and exit out gracefully.