Skip to content

feat: add armv6/armv7 (32-bit ARM) release builds #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manaporkun wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −1
Open

feat: add armv6/armv7 (32-bit ARM) release builds #151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
602e2a1
feat: add armv6/armv7 (32-bit ARM) release builds
manaporkun Apr 4, 2026
962cd87
fix: add ignore rules for non-linux ARM and include ARM variant in ar…
manaporkun Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,22 @@ builds:
goarch:
- amd64
- arm64
- arm
goarm:
- "6"
- "7"
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With goos including darwin and windows, adding arm to goarch will make GoReleaser attempt unsupported target pairs (e.g., darwin/arm and likely windows/arm), which will fail the release build. Consider splitting into a separate build entry for linux/arm only, or add ignore rules to exclude non-linux arm targets.

Suggested change
- "7"
- "7"
ignore:
- goos: darwin
goarch: arm
- goos: windows
goarch: arm

Copilot uses AI. Check for mistakes.
Comment on lines +21 to +24
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding goarm builds for both 6 and 7 will produce multiple artifacts with the same .Os/.Arch (linux/arm), but archives.name_template currently omits {{ .Arm }}. This can cause archive name collisions/overwrites (and incorrect checksums/formula URLs). Update the archive naming (and any related URL templates) to include the ARM variant for arm builds.

Copilot uses AI. Check for mistakes.
ignore:
- goos: darwin
goarch: arm
- goos: windows
goarch: arm
ldflags:
- -s -w -X main.version={{.Version}}

archives:
- formats:
- tar.gz
name_template: "{{ .ProjectName }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}"
name_template: "{{ .ProjectName }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}{{- if .Arm }}v{{ .Arm }}{{ end }}"
format_overrides:
- goos: windows
formats:
Expand Down