fix: tolerate missing directory in session upsert mutations for cloud sync#250
Open
quirozino wants to merge 1 commit intoGentleman-Programming:mainfrom
Open
Conversation
… sync When the MCP server generates session upsert mutations (e.g. for manual-save sessions), it may omit the directory field. The cloud sync canonicalizer was failing hard with an error instead of using a safe fallback. Replace the hard error with a fallback to '.' so cloud sync is not blocked by sessions created without a working directory. Fixes Gentleman-Programming#249
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
When using the MCP server with
ENGRAM_CLOUD_AUTOSYNC=1, cloud sync fails with:Root Cause
The MCP server generates
sync_mutationsentries forsessionupserts that are missing thedirectoryfield in the JSON payload. Example of a problematic mutation payload:{"id":"manual-save-ddata","project":"ddata","started_at":"2026-04-18 00:41:04"}The
directoryfield is absent entirely (not empty string, but missing). The cloud chunk canonicalizer requires this field for session upserts and fails hard with no fallback.Repro Steps
ENGRAM_CLOUD_AUTOSYNC=1and a cloud endpointmem_savetool from the MCP multiple times in a sessionengram sync --cloud --project <name>mutations[N]: session payload directory is required for upsertWorkaround
Manually patch the affected rows before syncing:
Expected Behavior
Either:
directoryin session mutation payloadsdirectoryand use a fallback from thesessionstableEnvironment