Fix #2367 Pending indicator CSS fixes for Filter and Update Metadata button#2369
Fix #2367 Pending indicator CSS fixes for Filter and Update Metadata button#2369allyoucanmap merged 2 commits intoGeoNode:masterfrom
Conversation
Summary of ChangesHello @anup39, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical UI issue where the pending and success change indicators were not visible when users interacted with the Filter and Update Metadata buttons. By introducing specific styling for these indicators, the PR significantly enhances user feedback and clarity regarding the state of ongoing operations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds CSS rules to display a pending changes indicator. The implementation correctly styles the pending icon, but it also incorrectly applies a warning color to the success icon. My review includes a suggestion to fix this to avoid user confusion and ensure the UI reflects the correct state.
| .gn-pending-changes-icon, | ||
| .gn-success-changes-icon { |
There was a problem hiding this comment.
The selector .gn-success-changes-icon is being styled with a warning color. This is semantically incorrect and could confuse users, as a success indicator should have a success color, not a warning one. Since this pull request is focused on fixing the pending indicator, it's best to remove the style for the success icon from this rule to avoid introducing a UI inconsistency.
.gn-pending-changes-icon {
| .gn-pending-changes-icon, | ||
| .gn-success-changes-icon { |
There was a problem hiding this comment.
please don't include new classes in geonode and use instead the one provided by mapstore, so replace these classes in the component with ms-notification-circle warning
This PR fix the following issue:
Pending changes indicator is not displayed when using the Filter button or the Update Metadata button.
Issue: #2367
Screen shots after fix :

