Skip to content

Comments

Fix #2367 Pending indicator CSS fixes for Filter and Update Metadata button#2369

Merged
allyoucanmap merged 2 commits intoGeoNode:masterfrom
anup39:fix_2367_inicator
Feb 5, 2026
Merged

Fix #2367 Pending indicator CSS fixes for Filter and Update Metadata button#2369
allyoucanmap merged 2 commits intoGeoNode:masterfrom
anup39:fix_2367_inicator

Conversation

@anup39
Copy link
Member

@anup39 anup39 commented Feb 2, 2026

This PR fix the following issue:

Pending changes indicator is not displayed when using the Filter button or the Update Metadata button.

Issue: #2367

Screen shots after fix :
Screenshot 2026-02-02 at 18 36 50
Screenshot 2026-02-02 at 18 40 48

@gemini-code-assist
Copy link

Summary of Changes

Hello @anup39, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical UI issue where the pending and success change indicators were not visible when users interacted with the Filter and Update Metadata buttons. By introducing specific styling for these indicators, the PR significantly enhances user feedback and clarity regarding the state of ongoing operations.

Highlights

  • CSS Fix: Added CSS rules to the _base.less file to ensure that the .gn-pending-changes-icon and .gn-success-changes-icon elements correctly display their background color, making them visible when indicating pending or successful changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds CSS rules to display a pending changes indicator. The implementation correctly styles the pending icon, but it also incorrectly applies a warning color to the success icon. My review includes a suggestion to fix this to avoid user confusion and ensure the UI reflects the correct state.

Comment on lines 70 to 71
.gn-pending-changes-icon,
.gn-success-changes-icon {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The selector .gn-success-changes-icon is being styled with a warning color. This is semantically incorrect and could confuse users, as a success indicator should have a success color, not a warning one. Since this pull request is focused on fixing the pending indicator, it's best to remove the style for the success icon from this rule to avoid introducing a UI inconsistency.

    .gn-pending-changes-icon {

@anup39 anup39 added Backport 5.0.x bug Something isn't working and removed master labels Feb 2, 2026
Comment on lines 70 to 71
.gn-pending-changes-icon,
.gn-success-changes-icon {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't include new classes in geonode and use instead the one provided by mapstore, so replace these classes in the component with ms-notification-circle warning

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@allyoucanmap allyoucanmap merged commit c5fd9ac into GeoNode:master Feb 5, 2026
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 24, 2026
@anup39 anup39 added the master label Feb 24, 2026
@anup39 anup39 added this to the 5.0.1 milestone Feb 24, 2026
allyoucanmap pushed a commit that referenced this pull request Feb 25, 2026
…button (#2369) (#2393)

(cherry picked from commit c5fd9ac)

Co-authored-by: Anup Dahal <adahal39@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pending changes indicator not visible for Filter and Update Metadata actions

2 participants