Add the support for CRS selector#2376
Conversation
Summary of ChangesHello @subashtiwari1010, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the application by integrating a Coordinate Reference System (CRS) selector, allowing users to specify and modify map projections. It includes logic to intelligently enable or disable CRS editing based on user permissions and the type of resource being managed, ensuring that only authorized users can make such changes. The update also configures the application to support this new functionality with a set of default projection options. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for the CRS selector plugin. The changes include adding the CRSSelector plugin to the localConfig.json for the map viewer and implementing a new Redux epic, gnUpdateEditProjectionEpic, to control when the projection can be edited. The logic in the new epic is correct, but I've suggested a small refactoring to improve maintainability by extracting a duplicated piece of logic into a shared function. Overall, the changes look good and address the intended feature.
55a408d to
e9a6e91
Compare
There was a problem hiding this comment.
@subashtiwari1010 In all existing or newly created maps the selector works correctly, even when configuring new projectionDefs.
However, the new control does not appear in the dataset viewer. I couldn't figure out if this is desired or if it needs to be configured for this section as well. The related issue doesn't say anything about this.
crs_dataset.mp4
The control should also be available for dataset viewers. It was implicit to me. |
…client into fix/crs-selecor
Related tasks
Fixes #2373
Describe this PR
This PR adds the support for the CRS selector. It updates the localConfig as well as adds the functionality to edit the selected CRS. It also updates the submodule to latest.