Skip to content

Comments

Add the support for CRS selector#2376

Merged
stefanocudini merged 9 commits intoGeoNode:masterfrom
subashtiwari1010:fix/crs-selecor
Feb 25, 2026
Merged

Add the support for CRS selector#2376
stefanocudini merged 9 commits intoGeoNode:masterfrom
subashtiwari1010:fix/crs-selecor

Conversation

@subashtiwari1010
Copy link

@subashtiwari1010 subashtiwari1010 commented Feb 4, 2026

Related tasks

Fixes #2373

Describe this PR

This PR adds the support for the CRS selector. It updates the localConfig as well as adds the functionality to edit the selected CRS. It also updates the submodule to latest.

@subashtiwari1010 subashtiwari1010 added this to the 5.1.0 milestone Feb 4, 2026
@subashtiwari1010 subashtiwari1010 added the enhancement New feature or request label Feb 4, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @subashtiwari1010, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application by integrating a Coordinate Reference System (CRS) selector, allowing users to specify and modify map projections. It includes logic to intelligently enable or disable CRS editing based on user permissions and the type of resource being managed, ensuring that only authorized users can make such changes. The update also configures the application to support this new functionality with a set of default projection options.

Highlights

  • CRS Selector Plugin Integration: The pull request introduces the CRS (Coordinate Reference System) selector plugin, enabling users to choose and manage projections for maps.
  • Dynamic CRS Editability: A new epic, gnUpdateEditProjectionEpic, has been added to dynamically control whether a user can edit the CRS. This is determined by the resource type (specifically maps) and the user's permissions (e.g., change_resourcebase or if it's a new resource).
  • Configuration Update: The localConfig.json file has been updated to include the CRSSelector plugin, pre-configured with common projections like EPSG:4326 and EPSG:3857 as available options.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • geonode_mapstore_client/client/js/epics/gnresource.js
    • Imported MAP_CONFIG_LOADED and setCanEditProjection actions to support CRS functionality.
    • Added gnUpdateEditProjectionEpic to manage the editability of map projections based on resource type and user permissions.
    • Exported the newly created gnUpdateEditProjectionEpic.
  • geonode_mapstore_client/static/mapstore/configs/localConfig.json
    • Added the CRSSelector plugin configuration.
    • Configured availableProjections for the CRS selector, including EPSG:4326 and EPSG:3857.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@subashtiwari1010 subashtiwari1010 changed the title Add the CRS plugin support Add the support for CRS selector Feb 4, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the CRS selector plugin. The changes include adding the CRSSelector plugin to the localConfig.json for the map viewer and implementing a new Redux epic, gnUpdateEditProjectionEpic, to control when the projection can be edited. The logic in the new epic is correct, but I've suggested a small refactoring to improve maintainability by extracting a duplicated piece of logic into a shared function. Overall, the changes look good and address the intended feature.

Copy link
Member

@stefanocudini stefanocudini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subashtiwari1010 In all existing or newly created maps the selector works correctly, even when configuring new projectionDefs.
However, the new control does not appear in the dataset viewer. I couldn't figure out if this is desired or if it needs to be configured for this section as well. The related issue doesn't say anything about this.

crs_dataset.mp4

@giohappy
Copy link

However, the new control does not appear in the dataset viewer. I couldn't figure out if this is desired or if it needs to be configured for this section as well. The related issue doesn't say anything about this.

The control should also be available for dataset viewers. It was implicit to me.
@subashtiwari1010 can you check?

@stefanocudini stefanocudini merged commit 465b70e into GeoNode:master Feb 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for CRS selector

4 participants