Update the css for the new button and border radius design#2387
Update the css for the new button and border radius design#2387allyoucanmap merged 6 commits intoGeoNode:masterfrom
Conversation
Summary of ChangesHello @subashtiwari1010, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the GeoNode client's user interface by integrating updated design specifications for buttons and border radii. This is primarily achieved through an update to the MapStore2 submodule, which provides the new design assets. To ensure a cohesive look and reduce maintenance overhead, custom CSS variable overrides for border-radius and button/icon sizing within the GeoNode theme have been removed, allowing the application to leverage the default styling provided by the updated MapStore2. This streamlines the styling process and promotes visual consistency across the application. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the MapStore submodule and adjusts the local styles to align with the new designs for buttons and border radius. The changes primarily involve removing local overrides for CSS variables like border-radius and button sizes, allowing the application to inherit these styles from MapStore. Additionally, hardcoded border-radius values have been replaced with the @border-radius-base variable for better consistency and maintainability. The changes are well-aligned with the PR's goal and represent a good step towards better style integration with MapStore. The code looks clean and the changes are correct.
allyoucanmap
requested review from
anup39
and removed request for
allyoucanmap
anup39
left a comment
anup39
left a comment
There was a problem hiding this comment.
@subashtiwari1010 I have checked all the buttons and looks fine to me. There is a minor change we can do in one place. These button I think do not require border radius .
Select Files and Add from URL
3 participants
Related tasks
Fixes #2386
Describe this PR
This PR updates the submodule to include the new designs for the buttons and border radius. It removes some of the overrides made to the variables from the MapStore.