Skip to content

[Fixes #14144] Upgrade django allauth#14145

Open
sijandh35 wants to merge 4 commits intomasterfrom
ISSUE_14144
Open

[Fixes #14144] Upgrade django allauth#14145
sijandh35 wants to merge 4 commits intomasterfrom
ISSUE_14144

Conversation

@sijandh35
Copy link
Copy Markdown
Contributor

@sijandh35 sijandh35 commented Apr 17, 2026

Fixes #14144

Changes:

  • Upgrade django-allauth to 65.16.0.
  • Update the necessary code for the upgrade, including handling deprecated allauth settings warnings.
  • Port the test from allauth.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Apr 17, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades django-allauth to version 65.16.0 and migrates deprecated authentication settings to the new ACCOUNT_SIGNUP_FIELDS and ACCOUNT_LOGIN_METHODS configuration, while maintaining backward compatibility. It also introduces new test utilities for OpenID Connect and updates documentation and serializers accordingly. Feedback points out a potential AttributeError in the test suite, a grammatical error in the documentation, and suggests improvements for request method checks and test assertions.

Comment thread docs/src/setup/configuration/settings.md Outdated
email = data.get("email")
# Email is required on post
if request.method in ("POST") and settings.ACCOUNT_EMAIL_REQUIRED and not email:
if request.method in ("POST") and "email*" in getattr(settings, "ACCOUNT_SIGNUP_FIELDS", []) and not email:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The expression request.method in ("POST") is logically equivalent to request.method in "POST" because ("POST") is a string literal, not a tuple. This could lead to unexpected behavior if request.method were a substring of "POST" (e.g., "P"). It is safer and clearer to use equality or a proper tuple.

Suggested change
if request.method in ("POST") and "email*" in getattr(settings, "ACCOUNT_SIGNUP_FIELDS", []) and not email:
if request.method == "POST" and "email*" in getattr(settings, "ACCOUNT_SIGNUP_FIELDS", []) and not email:

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 68.20084% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.51%. Comparing base (94ca636) to head (0895dfa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14145      +/-   ##
==========================================
- Coverage   74.62%   74.51%   -0.12%     
==========================================
  Files         958      959       +1     
  Lines       57891    58198     +307     
  Branches     7889     7946      +57     
==========================================
+ Hits        43202    43364     +162     
- Misses      12927    13053     +126     
- Partials     1762     1781      +19     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sijandh35 and others added 3 commits April 17, 2026 12:26
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Django Allauth

2 participants