Sync UI language selection with user profile settings by Gpetrak · Pull Request #14151 · GeoNode/geonode

Gpetrak · 2026-04-20T09:10:43Z

This PR was created according to this issue: #14150

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

Confirm you have read the contribution guidelines
You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
The issue connected to the PR must have Labels and Milestone assigned
PR for bug fixes and small new features are presented as a single commit
PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

gemini-code-assist

Code Review

This pull request implements a user language preference system by introducing a new ProfileLanguageMiddleware, updating the profile form and admin interface, and adding a view to handle language selection. Feedback focuses on ensuring the user profile remains the source of truth for language settings, avoiding constant duplication, and persisting language changes to the database for authenticated users.

gemini-code-assist · 2026-04-20T09:12:04Z

+        lang = request.session.get(SESSION_LANG_KEY)
+
+        if not lang:
+            lang = getattr(request.user, "language", None)
+            if lang:
+                request.session[SESSION_LANG_KEY] = lang


The current logic prioritizes the session value even if the user's profile language has been updated (e.g., via the profile edit form). For authenticated users, the profile should be the source of truth to ensure consistency across the application. Additionally, this suggestion avoids redundant session writes by only updating the session if the value has actually changed.

Suggested change

lang = request.session.get(SESSION_LANG_KEY)

if not lang:

lang = getattr(request.user, "language", None)

if lang:

request.session[SESSION_LANG_KEY] = lang

lang = getattr(request.user, "language", None)

if lang and request.session.get(SESSION_LANG_KEY) != lang:

request.session[SESSION_LANG_KEY] = lang

The proposed change would re-sync the session from the DB on every request and undo user language changes from the UI, so I’m keeping the current logic

gemini-code-assist · 2026-04-20T09:12:04Z

        return qs
+
+
+SESSION_LANG_KEY = "language_override"


The constant SESSION_LANG_KEY is already defined in geonode/base/middleware.py. It should be imported from there to avoid duplication and maintain a single source of truth.

Suggested change

SESSION_LANG_KEY = "language_override"

from geonode.base.middleware import SESSION_LANG_KEY

gemini-code-assist · 2026-04-20T09:12:04Z

+    if lang_code and check_for_language(lang_code):
+        request.session[SESSION_LANG_KEY] = lang_code


To fully synchronize the UI language selection with the user profile as intended, the selected language should be persisted to the user's profile when they are authenticated. This ensures the preference is preserved across different sessions and devices.

Suggested change

if lang_code and check_for_language(lang_code):

request.session[SESSION_LANG_KEY] = lang_code

if lang_code and check_for_language(lang_code):

request.session[SESSION_LANG_KEY] = lang_code

if request.user.is_authenticated:

request.user.language = lang_code

request.user.save(update_fields=["language"])

This would change the semantics of the topbar switcher from a session-only override to a persistent profile update. So I will keep the current approach.

codecov · 2026-04-21T07:31:19Z

Codecov Report

❌ Patch coverage is 31.42857% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.59%. Comparing base (94ca636) to head (80b537e).
⚠️ Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (94ca636) and HEAD (80b537e). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (94ca636) HEAD (80b537e)

7 6

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #14151       +/-   ##
===========================================
- Coverage   74.62%   52.59%   -22.03%     
===========================================
  Files         958      958               
  Lines       57891    58110      +219     
  Branches     7889     7930       +41     
===========================================
- Hits        43202    30564    -12638     
- Misses      12927    26103    +13176     
+ Partials     1762     1443      -319

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mattiagiupponi · 2026-04-23T11:05:38Z

    )

+    # This setting includes supported Maptstore language choices in a DB-based format
+    PROFILE_LANGUAGE_CHOICES = tuple((code.split("-")[0].lower(), label) for code, label in MAPSTORE_DEFAULT_LANGUAGES)


can't we use the get_2letters_languages utils with some changes?

@mattiagiupponi thanks for the comment. Ini my opinion, the idea in this setting is to completely be synced with the Mapstore supported languages. I'm afraid that if we use / modify this method, we will add a bit of complexity and it will not such clear that the source of truth here is the supported Mapstore language.

Gpetrak added 2 commits April 17, 2026 12:42

adding language field to the profile / users admin pages

f8aa5cc

create the language-related custom middleware and view

e970bc6

Gpetrak added this to the 5.1.0 milestone Apr 20, 2026

Gpetrak requested review from mattiagiupponi and sijandh35 April 20, 2026 09:10

Gpetrak assigned mattiagiupponi Apr 20, 2026

Gpetrak added the enhancement label Apr 20, 2026

cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Apr 20, 2026

gemini-code-assist Bot reviewed Apr 20, 2026

View reviewed changes

Gpetrak added 3 commits April 20, 2026 13:34

adding a tooltip in the language field

3ddfae9

Remove the duplicate definition of SESSION_LANG_KEY

04d14be

writing tests

da06037

Gpetrak marked this pull request as ready for review April 21, 2026 07:19

giohappy removed this from the 5.1.0 milestone Apr 22, 2026

using topbar switcher to store the lang to the db

109886d

Gpetrak linked an issue Apr 23, 2026 that may be closed by this pull request

Sync UI language selection with user profile settings #14150

Open

mattiagiupponi requested changes Apr 23, 2026

View reviewed changes

Merge branch 'master' into ISSUE_14150

80b537e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync UI language selection with user profile settings#14151

Sync UI language selection with user profile settings#14151
Gpetrak wants to merge 7 commits intomasterfrom
ISSUE_14150

Gpetrak commented Apr 20, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 20, 2026

Uh oh!

Gpetrak Apr 20, 2026

Uh oh!

gemini-code-assist Bot Apr 20, 2026

Uh oh!

Gpetrak Apr 20, 2026

Uh oh!

gemini-code-assist Bot Apr 20, 2026

Uh oh!

Gpetrak Apr 20, 2026

Uh oh!

codecov Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

mattiagiupponi Apr 23, 2026

Uh oh!

Gpetrak Apr 24, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	SESSION_LANG_KEY = "language_override"
	from geonode.base.middleware import SESSION_LANG_KEY

		if lang_code and check_for_language(lang_code):
		request.session[SESSION_LANG_KEY] = lang_code

Conversation

Gpetrak commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Gpetrak Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Gpetrak Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Gpetrak Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mattiagiupponi Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Gpetrak Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Gpetrak commented Apr 20, 2026 •

edited

Loading

codecov Bot commented Apr 21, 2026 •

edited

Loading

Gpetrak Apr 24, 2026 •

edited

Loading