Skip to content

fix(OpenGeode): update abseil#173

Merged
BotellaA merged 3 commits intonextfrom
fix/absl2026
Apr 1, 2026
Merged

fix(OpenGeode): update abseil#173
BotellaA merged 3 commits intonextfrom
fix/absl2026

Conversation

@BotellaA
Copy link
Copy Markdown
Member

@BotellaA BotellaA commented Apr 1, 2026

No description provided.

@BotellaA BotellaA requested a review from panquez April 1, 2026 14:03
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 4 concern(s)
  • src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:89:9: warning: [google-explicit-constructor]

    single-argument constructors must be marked explicit to avoid unintentional implicit conversions

       89 |         Impl( const SolidMesh< dimension >& mesh )
          |         ^
          |         explicit 
  • src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:95:9: warning: [modernize-use-nodiscard]

    function 'mesh_edges_are_manifold' should be marked [[nodiscard]]

       95 |         bool mesh_edges_are_manifold() const
          |         ^
          |         [[nodiscard]] 
  • src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:120:9: warning: [modernize-use-nodiscard]

    function 'non_manifold_edges' should be marked [[nodiscard]]

      120 |         InspectionIssues< std::array< index_t, 2 > > non_manifold_edges() const
          |         ^
          |         [[nodiscard]] 
  • src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:120:54: warning: [readability-function-cognitive-complexity]

    function 'non_manifold_edges' has cognitive complexity of 12 (threshold 10)

      120 |         InspectionIssues< std::array< index_t, 2 > > non_manifold_edges() const
          |                                                      ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:126:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      126 |             for( const auto polyhedron_id : Range{ mesh_.nb_polyhedra() } )
          |             ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:128:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      128 |                 for( const auto polyhedron_edge_vertices :
          |                 ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:132:21: note: +3, including nesting penalty of 2, nesting level increased to 3
      132 |                     if( !checked_edges.insert( polyhedron_edge ).second )
          |                     ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:138:25: note: +3, including nesting penalty of 2, nesting level increased to 3
      138 |                         if( !polyhedra_around_edge_are_the_same(
          |                         ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:152:21: note: +3, including nesting penalty of 2, nesting level increased to 3
      152 |                     catch( const OpenGeodeException& )
          |                     ^

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit 6c514ac into next Apr 1, 2026
19 checks passed
@BotellaA BotellaA deleted the fix/absl2026 branch April 1, 2026 18:19
@BotellaA
Copy link
Copy Markdown
Member Author

BotellaA commented Apr 1, 2026

🎉 This PR is included in version 6.8.19-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA
Copy link
Copy Markdown
Member Author

BotellaA commented Apr 2, 2026

🎉 This PR is included in version 6.8.19 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants