Skip to content

feat(SurfaceMeshHelpers): Added the computation of surface mesh stati…#1259

Open
MelchiorSchuh wants to merge 3 commits intonextfrom
fix/add_surface_mesh_statistics
Open

feat(SurfaceMeshHelpers): Added the computation of surface mesh stati…#1259
MelchiorSchuh wants to merge 3 commits intonextfrom
fix/add_surface_mesh_statistics

Conversation

@MelchiorSchuh
Copy link
Copy Markdown
Member

…stics to know current mesh metrics

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 1 concern(s)
  • src/geode/mesh/helpers/mesh_statistics.cpp:37:34: warning: [readability-function-cognitive-complexity]

    function 'compute_surface_metrics' has cognitive complexity of 11 (threshold 10)

       37 |     [[nodiscard]] MeshStatistics compute_surface_metrics(
          |                                  ^
    /__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/mesh_statistics.cpp:42:9: note: +1, including nesting penalty of 0, nesting level increased to 1
       42 |         for( const auto polygon_id : Range{ mesh.nb_polygons() } )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/mesh_statistics.cpp:44:13: note: +2, including nesting penalty of 1, nesting level increased to 2
       44 |             for( const auto edge_id :
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/mesh_statistics.cpp:48:17: note: +3, including nesting penalty of 2, nesting level increased to 3
       48 |                 if( const auto adjacent =
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/mesh_statistics.cpp:51:21: note: +4, including nesting penalty of 3, nesting level increased to 4
       51 |                     if( adjacent.value() < polygon_id )
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/mesh_statistics.cpp:63:9: note: +1, including nesting penalty of 0, nesting level increased to 1
       63 |         if( nb_edges != 0 )
          |         ^

Have any feedback or feature suggestions? Share it here.

Comment thread include/geode/mesh/helpers/mesh_statistics.hpp Outdated
Comment thread include/geode/mesh/helpers/mesh_statistics.hpp Outdated
Comment thread include/geode/mesh/helpers/mesh_statistics.hpp Outdated
@MelchiorSchuh MelchiorSchuh requested a review from panquez April 15, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants