Skip to content

Centralizes parameter utilities & fixes parameter bugs#127

Merged
aaront merged 13 commits intomainfrom
results-limit-bug-async
Sep 4, 2025
Merged

Centralizes parameter utilities & fixes parameter bugs#127
aaront merged 13 commits intomainfrom
results-limit-bug-async

Conversation

@aaront
Copy link
Contributor

@aaront aaront commented Aug 6, 2025

  • Centralizes parameter utilities
  • Fixes issue when using Python snake_case for resultsLimit
  • Cleans up imports

Fixes issue when using Python snake_case for resultsLimit
Cleans up imports
@aaront aaront requested a review from Copilot August 6, 2025 04:29
@aaront aaront self-assigned this Aug 6, 2025

This comment was marked as outdated.

@aaront aaront requested a review from Copilot August 6, 2025 15:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes parameter utilities into a new parameters.py module and fixes a bug with Python snake_case parameter naming for resultsLimit. The changes improve code organization by consolidating parameter processing logic and ensure consistent handling of both camelCase and snake_case parameter formats.

Key changes:

  • Creates new mygeotab/parameters.py module with centralized parameter utilities
  • Fixes bug where results_limit (snake_case) wasn't properly converted to resultsLimit
  • Updates imports to use relative imports and removes duplicate code

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
mygeotab/parameters.py New module containing centralized parameter utilities including camelcaseify_parameters and convert_get_parameters functions
tests/test_parameters.py Comprehensive test suite for the new parameter utilities covering various scenarios
mygeotab/api.py Refactored to use centralized parameter functions and removed duplicate process_parameters function
mygeotab/api_async.py Updated to use centralized parameter functions and improved imports
mygeotab/cli.py Updated imports to use relative imports and removed unused imports
mygeotab/serializers.py Changed to relative import
pyproject.toml Removed Black configuration and added Ruff formatting options
Various files Code formatting improvements and import cleanup

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.09%. Comparing base (49aaa0f) to head (556879b).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   56.85%   57.09%   +0.23%     
==========================================
  Files           8        9       +1     
  Lines         540      543       +3     
  Branches       94       97       +3     
==========================================
+ Hits          307      310       +3     
+ Misses        213      212       -1     
- Partials       20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aaront aaront merged commit 404d29b into main Sep 4, 2025
3 checks passed
@aaront aaront deleted the results-limit-bug-async branch September 4, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants