EMB-27360: Add enum for SubAck and ClearSubsAck.#315
Open
peter-lasota wants to merge 5 commits intoGeotab:masterfrom
Open
EMB-27360: Add enum for SubAck and ClearSubsAck.#315peter-lasota wants to merge 5 commits intoGeotab:masterfrom
peter-lasota wants to merge 5 commits intoGeotab:masterfrom
Conversation
dharatishah
approved these changes
Jun 21, 2023
| SUB_ACK_RESULT_SUBSCRIPTION_NOT_AVAILABLE = 6; | ||
| SUB_ACK_RESULT_UNAVAILABLE = 6; | ||
| // IOX Pub/Sub is not enabled by Master Switch. | ||
| SUB_ACK_RESULT_DISABLED = 7; |
There was a problem hiding this comment.
Please mention the master switch and how sending sub request would be responded by each message in the message description of 0x8C/0x26. Only adding enums are not enough.
| </code> | ||
|
|
||
| ``` | ||
| Note: The IOX Pub/Sub is controlled by a Master-Switch. When IOX Pub/Sub is not enabled: |
There was a problem hiding this comment.
Can you please move this up at the beginning of Appendix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New enum for SubAck and ClearSubsAck messages.