Refactor PrometheusController + Tests + Errors, MetricsService and MessageService and their Dependencies to AutomaUtilities#198
Merged
vimscientist69 merged 12 commits intodevelopfrom Oct 14, 2025
Conversation
automa utilities package Need to merge automa utilities refactor branch to master, update packages in this repository, and build package and fix any small errors that might arise
…ervice to automa utilities package
MessageService is in AutomaUtilities package now. Metric removed in this commit is added in AutomaUtilities.
…controller from automa utilities This removes the need of an authentication token to prevent leaking metrics. It works, because `PrometheusService` starts up a separate HTTP server on a different port that is not exposed publicly.
…so that automa utilities package can be cloned
This is needed to clone AutomaUtilities, a private Github repository. This commit also exposes the metrics port in both dockerfiles
5261dcb to
b52eacd
Compare
4510065 to
fe1111e
Compare
… core api Made method to get website html. Updated AutomaUtilities to have the web core api endpoint payload type.
…urce action can clone private repo - automautilities
… opensource action can clone private repo - automautilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
PrometheusController,MetricsServiceandMessageServicewill be used in packages and repositories other than Backend package and AutomaInfraCore repository. Moving these structs to AutomaUtilities will allow other repositories and Swift packages to use them as well.Tech Details List
MetricsService,PrometheusController,PrometheusControllerErrorsandPrometheusControllerIntegrationTestsfrom AutomaInfracore to AutomaUtilities.MessageServiceintoMessageServiceandSNSService(message service just for discord messages, sns service for SMS's), and move MessageService along with all of its imported code from AutomaInfracore to AutomaUtilities.AutomaUtilitiespackage after refactor PR has been merged.AutomaUtilitiespackage whereMetricsService,PrometheusController,MessageServiceand their dependencies are usedTasks:
MetricsService,PrometheusController,PrometheusControllerErrorsandPrometheusControllerIntegrationTestsfrom AutomaInfracore to AutomaUtilities.MessageServiceintoMessageServiceandSNSService(message service just for discord messages, sns service for SMS's), and move MessageService along with all of its imported code from AutomaInfracore to AutomaUtilities.AutomaUtilitiespackage after refactor PR has been merged.AutomaUtilitiespackage whereMetricsService,PrometheusController,MessageServiceand their dependencies are usedUn-important tasks:
Links:
AutomaUtilities Refactor Pull Request (already merged)
Testing
Steps:
TESTING-QAOutput:
Testing QA