Clean Code | Refactor | Meaningful Logs | Better Error Handling#1
Merged
vimscientist69 merged 10 commits intomainfrom Sep 16, 2025
Merged
Clean Code | Refactor | Meaningful Logs | Better Error Handling#1vimscientist69 merged 10 commits intomainfrom
vimscientist69 merged 10 commits intomainfrom
Conversation
…idNodeAppInteractor Refactor autoscaler and autodestroyer to have short methods as well. Initialize authHeader as class instance to avoid getting it from payload every time (very long). Then, add meaningful logs.
…dler to its own class to reduce function parameter passing and length of interactor struct
Still have a lot of todos left (left comment on top).
vimscientist69
added a commit
that referenced
this pull request
Sep 18, 2025
vimscientist69
added a commit
that referenced
this pull request
Sep 18, 2025
vimscientist69
added a commit
that referenced
this pull request
Sep 18, 2025
vimscientist69
added a commit
that referenced
this pull request
Dec 18, 2025
* refactor(SeleniumGridNodeAppInteractor): short methods for SeleniumGridNodeAppInteractor Refactor autoscaler and autodestroyer to have short methods as well. Initialize authHeader as class instance to avoid getting it from payload every time (very long). Then, add meaningful logs. * refactor: refactored a lot of code, around 50% done * refactor(SeleniumGridNodeAppInteractor): done with refactoring * refactor(SeleniumGridNodeAppInteractor): refactored fly api error handler to its own class to reduce function parameter passing and length of interactor struct * refactor(SeleniumGridNodeAutoCreator): refactored name from autoscaler to autocreator * refactor(SeleniumGridAutoCreator): refactored some code in auto creator Still have a lot of todos left (left comment on top). * refactor: semi done with refactoring all code * refactor: more cleanup work * refactor: added meaningful logs * fix: fixed all swiftlint linting errors
vimscientist69
added a commit
that referenced
this pull request
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
Clean code with better error handling, no unnecessary code duplication and better logs are important for building a system that lasts.
Tech Details List
Tasks:
Un-important tasks:
Links:
Testing
Steps:
TESTING-QAOutput:
Testing QA