setAttribute() Method Implemented#49
Merged
vimscientist69 merged 1 commit intomasterfrom Aug 13, 2025
Merged
Conversation
written integration tests, tests passed as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
Reason for creating this pull request: fixes #48
Tech Details List
setAttribute()onChromeDriver, updating all protocols (DriverandWebDriver) so that any new drivers in the future also require asetAttribute()implementation.setAttribute()method, getting the attribute value afterwards to see if thesetAttribute()method actually changed the value of the attribute.Tasks:
setAttribute()onChromeDriver, updating all protocols (DriverandWebDriver) so that any new drivers in the future also require asetAttribute()implementation.setAttribute()method, getting the attribute value afterwards to see if thesetAttribute()method actually changed the value of the attribute.Un-important tasks:
No tasks here.
Links:
ISSUE-48
closes/resolves #48
Testing
Steps:
TESTING-QAOutput:
Swift test output:
Testing QA
Make sure to run
docker-compose upbefore running integration tests to start required services.