Skip to content

setProperty() Method Implemented#55

Merged
vimscientist69 merged 1 commit intomasterfrom
feat/set-property-method
Aug 13, 2025
Merged

setProperty() Method Implemented#55
vimscientist69 merged 1 commit intomasterfrom
feat/set-property-method

Conversation

@vimscientist69
Copy link

@vimscientist69 vimscientist69 commented Aug 13, 2025

Reason

Reason: fixes issue #54

Tech Details List

  1. Create a setProperty() method. Add it to the drivers protocols, and let ChromeDriver conform to it and have a valid and working implementation of setProperty().
  2. Write working integration tests

Tasks:

  • Create a setProperty() method. Add it to the drivers protocols, and let ChromeDriver conform to it and have a valid and working implementation of setProperty().
  • Write working integration tests

Un-important tasks:

No tasks here.

Links:

ISSUE-54
closes/resolves #54

Testing

Steps:

  1. Run required commands to test all the code modified by this PR
# unit tests
# integration tests
npm run compose:build-and-up
swift build ; swift test --filter "ChromeDriverPropertyIntegrationTests"
# procs / testing logic
  1. Further testing can be done by following the notes in TESTING-QA

Output:

❯ swift build ; swift test --filter "ChromeDriverPropertyIntegrationTests"
[1/1] Planning build
Building for debugging...
[1/1] Write swift-version--58304C5D6DBC2206.txt
Build complete! (1.65s)
[1/1] Planning build
Building for debugging...
[1/1] Write swift-version--58304C5D6DBC2206.txt
Build complete! (1.62s)
Test Suite 'Selected tests' started at 2025-08-13 13:34:01.798.
Test Suite 'swift-webdriverPackageTests.xctest' started at 2025-08-13 13:34:01.804.
Test Suite 'swift-webdriverPackageTests.xctest' passed at 2025-08-13 13:34:01.804.
         Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.000) seconds
Test Suite 'Selected tests' passed at 2025-08-13 13:34:01.804.
         Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.007) seconds
◇ Test run started.
↳ Testing Library Version: 124.4
↳ Target Platform: arm64e-apple-macos14.0
◇ Suite "Chrome Driver Property Integration Tests" started.
◇ Test "Get Property" started.
✔ Test "Get Property" passed after 3.095 seconds.
◇ Test "Set Property" started.
✔ Test "Set Property" passed after 2.944 seconds.
✔ Suite "Chrome Driver Property Integration Tests" passed after 6.040 seconds.
✔ Test run with 2 tests passed after 6.041 seconds.

Testing QA

Make sure to run npm run compose:build-and-up before running integration tests

added it to driver protocols, and wrote integration tests that are working as expected
@vimscientist69 vimscientist69 self-assigned this Aug 13, 2025
@vimscientist69 vimscientist69 merged commit 06a049b into master Aug 13, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature -> setProperty() method

1 participant