Draft
Conversation
Runs but still a lot to fix / improve
…ermining which iframe to use. Update the tabs to reset when the component changes
Deploying atlantis with
|
| Latest commit: |
55fdb50
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b20effad.atlantis.pages.dev |
| Branch Preview URL: | https://mike-migrate-to-tanstack-rou.atlantis.pages.dev |
MichaelParadis
commented
Feb 3, 2026
|
|
||
| useEffect(() => { | ||
| if (code) { | ||
| console.log("updating code"); |
… a mdx file for the sidebar navigation
…ate-to-tanstack-router
…ate-to-tanstack-router
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
There are some improvements we want to make to the doc site such as linking directly to tabs and using hashes to link directly to headings. While react-router-dom supports this type of stuff we are currently using a super old version (react router dom v5 which was last updated 2 years ago). Since it was such an old version finding resources for this version would be difficult.
In theory I could have updated react-router-dom on the docs site, however I decided to migrate to tanstack router for the following reasons:
Future work
window.locationand updating that manually instead of leveraging react-router-domi. In
useAtlantisPreviewViewerhereii. In
ComponentViewto determine the tab and update the preview based on the tab / version hereChanges
Added
Changed
Deprecated
Removed
Fixed
Security
Testing
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.