Skip to content

fix(components): POC rendering ReactDatePicker inside a portal#2912

Draft
jdeichert wants to merge 2 commits intomasterfrom
JOB-151560/poc-datepicker-portal
Draft

fix(components): POC rendering ReactDatePicker inside a portal#2912
jdeichert wants to merge 2 commits intomasterfrom
JOB-151560/poc-datepicker-portal

Conversation

@jdeichert
Copy link
Contributor

Motivations

WIP

Changes

Added

Changed

Deprecated

Removed

Fixed

Security

Testing

Changes can be
tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

pickerRef,
};
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues to resolve:

  1. Once focused inside the picker, escape closes both the picker and modal

  2. Focusing on the InputDate icon button, triggering with spacebar, and then tabbing again DOES NOT get you focused inside the picker (it should)

@cloudflare-workers-and-pages
Copy link

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 36ba086
Status: ✅  Deploy successful!
Preview URL: https://27556d63.atlantis.pages.dev
Branch Preview URL: https://job-151560-poc-datepicker-po.atlantis.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant