feat(ui): channel list item#2522
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
...es/stream_chat_flutter/lib/src/scroll_view/channel_scroll_view/stream_channel_list_tile.dart
Show resolved
Hide resolved
...es/stream_chat_flutter/lib/src/scroll_view/channel_scroll_view/stream_channel_list_tile.dart
Outdated
Show resolved
Hide resolved
| // TODO: make this configurable when the online state is shown. | ||
| showOnlineIndicator: otherUser.online, |
There was a problem hiding this comment.
We have to see how/where we want configurations like this.
There was a problem hiding this comment.
We might want a boolean in the StreamOnlineIndicatorTheme to show/hide offline states. Or maybe an enum.
enum StreamOnlineIndicatorBehaviour {
alwaysShow,
onlyShowOnline,
}There was a problem hiding this comment.
@xsahil03x This is going to be re-made anway right?
# Conflicts: # melos.yaml # packages/stream_chat_flutter/lib/src/scroll_view/channel_scroll_view/stream_channel_list_tile.dart # packages/stream_chat_flutter/lib/stream_chat_flutter.dart # packages/stream_chat_flutter/pubspec.yaml # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_dark.png # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_light.png # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_reversed_dark.png # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_reversed_light.png
…e/channel-list-item # Conflicts: # melos.yaml # packages/stream_chat_flutter/pubspec.yaml
| @override | ||
| Widget build(BuildContext context) { | ||
| final channelState = channel.state!; | ||
| final builder = StreamComponentFactory.of(context).extension<StreamChannelListItemProps>(); |
There was a problem hiding this comment.
we should use context.channelListItem instead, similar to composer
There was a problem hiding this comment.
Do you want 1 dart file for all builder extensions? I think we should keep it internal right?
There was a problem hiding this comment.
yeah, we can do it. also if we are planning to keep it internal then i am not against using the .of method
There was a problem hiding this comment.
Made an in between, just an extension for the long StreamComponentFactory.of(context).extension:
596f130
| path: ^1.8.3 | ||
| path_provider_platform_interface: ^2.0.0 | ||
| plugin_platform_interface: ^2.0.0 | ||
| theme_extensions_builder_annotation: ^7.1.0 |
There was a problem hiding this comment.
do we need this? and this should be in dependencies instead and builder should be added here
There was a problem hiding this comment.
I just moved the channel list theme from core. Let's think about it when we refactor the stream chat theme. For now I think it's useful, but indeed I'll move it.
renefloor
force-pushed
the
feature/channel-list-item
branch
from
2be3ab3 to
6b48600
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/design-refresh #2522 +/- ##
=======================================================
- Coverage 64.19% 63.91% -0.29%
=======================================================
Files 435 435
Lines 26214 26328 +114
=======================================================
- Hits 16829 16828 -1
- Misses 9385 9500 +115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Submit a pull request
Linear: FLU-379
CLA
Description of the pull request
This updates to the new channel list design.
Relevant PR: GetStream/stream-core-flutter#61
Screenshots / Videos