feat: global upload manager to track file uploads outside of AttachmentManager#1715
Open
feat: global upload manager to track file uploads outside of AttachmentManager#1715
Conversation
Contributor
|
Size Change: +3.47 kB (+0.94%) Total Size: 374 kB 📦 View Changed
|
9623734 to
392f437
Compare
6 tasks
MartinCupela
reviewed
Apr 8, 2026
MartinCupela
reviewed
Apr 8, 2026
c39d2bd to
7040f4c
Compare
isekovanic
reviewed
Apr 8, 2026
a2ce058 to
6357776
Compare
6357776 to
e985d60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
RN PR for reference: GetStream/stream-chat-react-native#3527
React Native allows hitting the send button before attachment uploads are completed. This means they need a way to track attachment upload status outside of
AttachmentManager.To solve this we have an
UploadManager(can be accessed viaclient.uploadManager) that uses theAttachmentManagerof a given channel to do attachment upload, and has a state to trackuploadProgressfor attachments.Attachments are tracked by
idinUploadManager.Long-term solution: we talked with @isekovanic that
messageComposershould have support for this feature, but that is a bigger task, not the scope of this PR.Changelog