Skip to content

chore: align ci titles#225

Open
mogita wants to merge 1 commit intomainfrom
chore/align-ci-titles
Open

chore: align ci titles#225
mogita wants to merge 1 commit intomainfrom
chore/align-ci-titles

Conversation

@mogita
Copy link
Contributor

@mogita mogita commented Mar 19, 2026

Summary by CodeRabbit

  • Chores
    • Reorganized CI test execution workflow to improve test suite management and separation.

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 91b0c043-99b9-4373-924d-c3066309fb7c

📥 Commits

Reviewing files that changed from the base of the PR and between bc2b6de and cf91fcc.

📒 Files selected for processing (1)
  • .github/workflows/run_tests.yml

📝 Walkthrough

Walkthrough

The GitHub Actions workflow is restructured to split a single test job into two parallel jobs: one executing non-video tests with expanded exclusions, and another running video-specific tests with the previously excluded components restored. Both use the same pytest command with identical credential sources but different test scope configurations.

Changes

Cohort / File(s) Summary
CI Test Workflow Restructuring
.github/workflows/run_tests.yml
Single test job split into test-non-video and test-video jobs. Non-video job explicitly excludes video module and six video-adjacent test files. Video job re-includes previously excluded components. Step label unified to "Run tests" across both jobs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Two paths diverge in the workflow's wood,
One hops through non-video, as it should,
The other bounds where streaming videos play,
Tests split and sorted in a cleaner way!
What busy work our CI does today!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'chore: align ci titles' is vague and does not convey the specific nature of the changes, which involve splitting a single test job into two separate jobs (test-non-video and test-video) with updated step labels and exclusions. Consider a more specific title that describes the main change, such as 'chore: split test job into video and non-video jobs' or 'chore: restructure CI test workflow for video/non-video separation'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/align-ci-titles
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the reusable CI workflow to better align test job titles and to separate “non-video” vs “video” test execution based on which Stream credentials are required.

Changes:

  • Renames/splits the prior test job into test-non-video and test-video with clearer job names per Python version.
  • Adjusts pytest invocation to exclude video-related code/tests from non-video runs and explicitly run video-related paths under video-enabled credentials.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +93 to +101
--ignore=tests/test_audio_stream_track.py \
--ignore=tests/test_connection_manager.py \
--ignore=tests/test_connection_utils.py \
--ignore=tests/test_signaling.py \
--ignore=tests/test_tracing_jaeger_manual.py \
--ignore=tests/test_video_examples.py \
--ignore=tests/test_video_integration.py \
--ignore=tests/test_video_openai.py \
--ignore=tests/test_signaling.py \
--ignore=tests/test_audio_stream_track.py \
--ignore=getstream/video
- name: Run video tests
--ignore=tests/test_webrtc_generation.py
Comment on lines +63 to +66
# ── Non-video tests (chat, feeds, etc.) ────────────────────────────
# Uses STREAM_CHAT_* credentials which do NOT have video enabled.
# If you add a new video-related test file, add it to the ignore
# list below AND to the test-video job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants