Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GitHub Actions workflow is restructured to split a single test job into two parallel jobs: one executing non-video tests with expanded exclusions, and another running video-specific tests with the previously excluded components restored. Both use the same pytest command with identical credential sources but different test scope configurations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the reusable CI workflow to better align test job titles and to separate “non-video” vs “video” test execution based on which Stream credentials are required.
Changes:
- Renames/splits the prior
testjob intotest-non-videoandtest-videowith clearer job names per Python version. - Adjusts pytest invocation to exclude video-related code/tests from non-video runs and explicitly run video-related paths under video-enabled credentials.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| --ignore=tests/test_audio_stream_track.py \ | ||
| --ignore=tests/test_connection_manager.py \ | ||
| --ignore=tests/test_connection_utils.py \ | ||
| --ignore=tests/test_signaling.py \ | ||
| --ignore=tests/test_tracing_jaeger_manual.py \ | ||
| --ignore=tests/test_video_examples.py \ | ||
| --ignore=tests/test_video_integration.py \ | ||
| --ignore=tests/test_video_openai.py \ | ||
| --ignore=tests/test_signaling.py \ | ||
| --ignore=tests/test_audio_stream_track.py \ | ||
| --ignore=getstream/video | ||
| - name: Run video tests | ||
| --ignore=tests/test_webrtc_generation.py |
| # ── Non-video tests (chat, feeds, etc.) ──────────────────────────── | ||
| # Uses STREAM_CHAT_* credentials which do NOT have video enabled. | ||
| # If you add a new video-related test file, add it to the ignore | ||
| # list below AND to the test-video job. |
Summary by CodeRabbit