Skip to content

Leave an active call when Telecom puts it to inactive or hold #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahul-lohra wants to merge 1 commit into
base: develop
Choose a base branch
from
+36 −0
Open

Leave an active call when Telecom puts it to inactive or hold #1622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ import io.getstream.video.android.core.notifications.IncomingNotificationData
import io.getstream.video.android.core.notifications.NotificationType
import io.getstream.video.android.core.notifications.internal.service.CallServiceConfig
import io.getstream.video.android.core.notifications.internal.telecom.jetpack.JetpackTelecomRepository
import io.getstream.video.android.core.notifications.internal.telecom.jetpack.TelecomCall
import io.getstream.video.android.core.permission.PermissionRequest
import io.getstream.video.android.core.pinning.PinType
import io.getstream.video.android.core.pinning.PinUpdateAtTime
Expand All @@ -130,6 +131,7 @@ import io.getstream.video.android.core.utils.toUser
import io.getstream.video.android.model.StreamCallId
import io.getstream.video.android.model.User
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.Job
import kotlinx.coroutines.channels.awaitClose
import kotlinx.coroutines.currentCoroutineContext
Expand All @@ -145,6 +147,7 @@ import kotlinx.coroutines.flow.combine
import kotlinx.coroutines.flow.debounce
import kotlinx.coroutines.flow.distinctUntilChanged
import kotlinx.coroutines.flow.flow
import kotlinx.coroutines.flow.map
import kotlinx.coroutines.flow.stateIn
import kotlinx.coroutines.flow.transform
import kotlinx.coroutines.isActive
Expand Down Expand Up @@ -720,8 +723,19 @@ public class CallState(
@InternalStreamVideoApi
public val notificationIdFlow: StateFlow<Int?> = _notificationIdFlow

private var telecomHoldObserverJob: Job? = null

@InternalStreamVideoApi
internal var jetpackTelecomRepository: JetpackTelecomRepository? = null
set(value) {
field = value
if (value != null) {
observeTelecomHold(value)
} else {
telecomHoldObserverJob?.cancel()
telecomHoldObserverJob = null
}
}

internal var incomingNotificationData = IncomingNotificationData(emptyMap())

Expand Down Expand Up @@ -1749,6 +1763,28 @@ public class CallState(
this._notificationIdFlow.value = notificationId
this.atomicNotification.set(notification)
}

/**
* [RingingState.Incoming] and [RingingState.Outgoing] are intentionally not observed.
* In Android Telecom, hold states are only applicable once a call is active (answered).
*/
private fun observeTelecomHold(repo: JetpackTelecomRepository) {
telecomHoldObserverJob?.cancel()

telecomHoldObserverJob = scope.launch(Dispatchers.Default) {
repo.currentCall
.map { (it as? TelecomCall.Registered)?.isOnHold == true }
.distinctUntilChanged()
.collect { telecomCall ->
when (ringingState.value) {
Copy link
Contributor

@aleksandar-apostolov aleksandar-apostolov Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .map produces a boolean (isOnHold) but the collected value is never checked — should there be a .filter { it } before .collect?

distinctUntilChanged() emits on both false → true and true → false transitions. If the setter re-fires while ringingState is already Active (e.g., Telecom re-registration), the new observer replays the current false and would trigger call.leave() immediately.

is RingingState.Active -> {
call.leave("call-on-hold")
}
else -> {}
}
}
}
}
}

private fun MemberResponse.toMemberState(): MemberState {
Expand Down
Loading