Skip to content

fix(client): don't overwrite call members on call.update #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jdimovska wants to merge 4 commits into
base: main
Choose a base branch
from
+20 −5
Draft

fix(client): don't overwrite call members on call.update #2147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90a009f
fix(client): don't overwrite call members on call.update
jdimovska Mar 2, 2026
48af3e4
Merge branch 'main' into update-members-issue
jdimovska Mar 19, 2026
1902ac1
merge main
jdimovska Mar 19, 2026
fa2ff0e
merge main
jdimovska Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/client/src/Call.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2436,9 +2436,8 @@ export class Call {
UpdateCallRequest
>(`${this.streamClientBasePath}`, updates);

const { call, members, own_capabilities } = response;
const { call, own_capabilities } = response;
this.state.updateFromCallResponse(call);
this.state.setMembers(members);
Copy link
Member

@oliverlaz oliverlaz Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this @jdimovska. This seems to be a backend bug; the SDK is implemented according to the OpenAPI contract.

this.state.setOwnCapabilities(own_capabilities);

return response;
Expand Down
17 changes: 17 additions & 0 deletions packages/client/src/__tests__/Call.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,23 @@ describe('state updates in reponse to coordinator API', () => {
expect(call.state.members[0].role).toBe('admin');
});

it('should not clear members when updating custom data', async () => {
await call.getOrCreate({
data: {
members: [{ user_id: 'sara' }, { user_id: 'jane' }],
},
});

expect(call.state.members.length).toBe(2);

await call.update({
custom: { messageId: 'test-message-id' },
});

expect(call.state.members.length).toBe(2);
expect(call.state.custom.messageId).toBe('test-message-id');
});

it('should get and update state', async () => {
await serverClient.video.call(call.type, call.id).create({
data: {
Expand Down
2 changes: 1 addition & 1 deletion sample-apps/react/react-dogfood/helpers/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const createTokenProvider = (
const params = new URLSearchParams({
user_id: userId || '!anon',
environment,
exp: String(4 * 60 * 60), // 4 hours
exp: String(60), // 4 hours
} satisfies CreateJwtTokenRequest);

const res = await fetch(`${basePath}/api/auth/create-token?${params}`);
Expand Down
3 changes: 1 addition & 2 deletions sample-apps/react/react-dogfood/helpers/jwt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ import { decodeBase64 } from 'stream-chat';
* The maximum validity of a token, in seconds.
* Defaults to 7 days.
*/
export const maxTokenValidityInSeconds: number =
Number(process.env.MAX_TOKEN_EXP_IN_SECONDS) || 7 * 24 * 60 * 60; // 7 days
export const maxTokenValidityInSeconds: number = 60;

export const createToken = async (
userId: string,
Expand Down
Loading