Skip to content

fix: set outgoing call active from callingstate#2172

Merged
santhoshvai merged 4 commits intofeat/callkit-telecom-integrationfrom
ios-outgoing
Mar 26, 2026
Merged

fix: set outgoing call active from callingstate#2172
santhoshvai merged 4 commits intofeat/callkit-telecom-integrationfrom
ios-outgoing

Conversation

@santhoshvai
Copy link
Copy Markdown
Member

💡 Overview

Outgoing call can start with ways

  1. getOrCreate( ring: true )
  2. join(ring: true)

we have to start reporting in callkit on 1 itself.. we did only on 2.. this PR fixes that

and also we now report that connection is done only after join.. so that we get correct time in callkit

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 24, 2026

⚠️ No Changeset found

Latest commit: 8eebbbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3db4ec32-4dfd-4227-8eac-dc0bffe9e9fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ios-outgoing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@santhoshvai santhoshvai merged commit ffb86a8 into feat/callkit-telecom-integration Mar 26, 2026
14 of 15 checks passed
@santhoshvai santhoshvai deleted the ios-outgoing branch March 26, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants