Fix arbitrary audit log ordering in 'get_id_change_date'#73
Merged
Conversation
ivanb777
changed the title
ivanb777
force-pushed
the
minor-fix-and-update-241126
branch
from
8884bc1 to
0cc4090
Compare
ivanb777
force-pushed
the
minor-fix-and-update-241126
branch
from
0cc4090 to
4553c5a
Compare
michael-gratton
suggested changes
Nov 27, 2024
ivanb777
force-pushed
the
minor-fix-and-update-241126
branch
from
4553c5a to
02fdc7e
Compare
michael-gratton
suggested changes
Nov 28, 2024
ivanb777
force-pushed
the
minor-fix-and-update-241126
branch
from
02fdc7e to
e7726fa
Compare
– Add tests for 'get_id_change_date' – Minor code fixes
ivanb777
force-pushed
the
minor-fix-and-update-241126
branch
from
e7726fa to
845c1f6
Compare
michael-gratton
approved these changes
Nov 28, 2024
Contributor
michael-gratton
left a comment
michael-gratton
left a comment
There was a problem hiding this comment.
Let's get this deployed to staging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_id_change_datemethod retrieves the actual timestamp of modified member attributes using audit logs. However, the ordering of audit logs was not explicitly defined, leading to potential inconsistencies in the returned modification timestamp. This issue could negatively impact the sync process by relying on incorrect timestamps.This fix ensures that audit logs are properly ordered, guaranteeing the accurate modification timestamp – improving the reliability of the sync process.