Skip to content

ci: drop redundant tags-ignore glob#5

Merged
Getty merged 1 commit into
mainfrom
ci/drop-tags-ignore-glob
Jun 23, 2026
Merged

ci: drop redundant tags-ignore glob#5
Getty merged 1 commit into
mainfrom
ci/drop-tags-ignore-glob

Conversation

@Getty

@Getty Getty commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Follow-up zu #4.

branches: ['**'] macht Tags zum undefined Git ref — laut GitHubs Filter-Regeln läuft ein push-Event dann gar nicht für Tags. Die dzil release-Tags (v0.NNN) haben also ohnehin nie gebaut.

tags-ignore: ['*'] war damit:

  1. redundant — Tag-Pushes triggern mit definiertem branches sowieso nicht;
  2. subtil falsch — es schaltet die Tag-Auswertung wieder ein, und ['*'] matcht keine Slash-Tags (z.B. releases/1.0), die dann doch gebaut hätten.

Entfernt. Verhalten danach: Branch-Pushes + PRs bauen, alle Tag-Pushes bauen nicht — ohne Glob-Sonderfall.

Offizielle Doku: "If you define only tags/tags-ignore or only branches/branches-ignore, the workflow won't run for events affecting the undefined Git ref."

🤖 Generated with Claude Code

With branches: ['**'] defined for the push event, tags are the "undefined
Git ref" — per GitHub's filter rules a push event won't run for tags at all,
so the dzil release tags (v0.NNN) already never triggered a build. The
tags-ignore: ['*'] line was therefore redundant, and worse, it re-enabled tag
evaluation while ['*'] doesn't match slashed tags (e.g. releases/1.0), which
would then have built. Removing it leaves: branch pushes + PRs build, all tag
pushes don't — no glob corner case.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Getty Getty merged commit 0df489a into main Jun 23, 2026
6 checks passed
@Getty Getty deleted the ci/drop-tags-ignore-glob branch June 23, 2026 02:43
Getty added a commit that referenced this pull request Jul 2, 2026
An unrecognized subcommand fell through MooX::Cmd dispatch into the
default board view and exited 0, so typos like `karr agent-name` looked
like success. Leftover bare-word positionals in the root execute now
die with "Unknown command: ..." (MooX::Cmd echoes parsed option flags
back into args, so dash-prefixed entries are ignored and bare
`karr` / `karr --done` still render the board).

`karr archive` was also the only id-taking command that exited 0 when
an id did not exist (warn + next, while show/move/edit/delete/handoff
all die). A missing id in the batch now exits 1 after the loop:
existing ids stay archived and reported — partial success committed,
overall failure signalled, matching kanban-md's runBatch semantics.
Re-archiving an already-archived task remains a successful no-op.

Adds t/41-cli-error-exits.t pinning the whole not-found matrix across
id-taking commands plus the unknown-command and bare-karr behaviors.

Closes karr tasks #5 and #6.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GLsGFe6Vt98jHpCJmBwmMi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant