- restructured the src directories to have khaya (as a base and util dir) as a subdirectory of kasa#59
- restructured the src directories to have khaya (as a base and util dir) as a subdirectory of kasa#59PhidLarkson wants to merge 1 commit intomasterfrom
Conversation
PhidLarkson
commented
May 7, 2025
PhidLarkson
commented
- refactoring and chages with imports
- performed tests (all 22 passed with 6 httpx deprecation errors)
…the util dir) as a subdirectory of kasa - refactoring and changes with imports - performed tests (all 22 passed with 6 httpx deprecation warnings) - identified tests fails a throws "Too Many Requests" error after running tests too closely
PhidLarkson
force-pushed
the
restructure-kasa-khaya
branch
from
b12fa22 to
547dc44
Compare
|
|
Lagyamfi
left a comment
Lagyamfi
left a comment
There was a problem hiding this comment.
Hey Prince, thanks for the review.
The idea is that khaya is meant for dealing with the api specifically. All other tools we will develop that dont involve the api will stay under kasa.
What is your reasoning behind moving the khaya directory under the kasa folder?
So when installing the library locally for improvement and testing I was finding it hard to access khaya, apparentlly from earlier discussions I understood khaya to be utils, so I renamed that for kasa to be the base with api service ojects, khaya remains the interface for the entire API use and then khaya directory carries the extras like preprocessing and batch processing. Then afterwards it was easier to use and call, effected that change in the tests as well |
|
@PhidLarkson So I think we will keep all preprocessing scripts or tools as part of kasa meaning any additional modules that we include in the library will be able to use it. And Khaya is an example of one of those modules that uses the utility tools in khaya. So in the end all the preprocessing and batching scripts should be moved into kasa and imported into khaya. |
2 participants
