Skip to content

Code quality cleanup#870

Merged
chrismaddalena merged 4 commits intomasterfrom
hotfix/code-quality-cleanup
Apr 14, 2026
Merged

Code quality cleanup#870
chrismaddalena merged 4 commits intomasterfrom
hotfix/code-quality-cleanup

Conversation

@chrismaddalena
Copy link
Copy Markdown
Collaborator

@chrismaddalena chrismaddalena commented Apr 14, 2026

This removes an unused template that could create confusion and removes an unneeded variable declaration from the oplog. It also includes revisions for the bug and feature templates.

Copilot AI review requested due to automatic review settings April 14, 2026 14:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a small cleanup in Ghostwriter by removing unused code/assets to reduce confusion and avoid dead/unused references in the oplog UI.

Changes:

  • Removed an unused jQuery DOM reference in the oplog JavaScript.
  • Deleted an unused Rolodex template snippet (formsets.html) that is not referenced anywhere in the codebase.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ghostwriter/static/js/oplog.js Drops an unused $detailPane variable (no remaining references found).
ghostwriter/rolodex/templates/snippets/formsets.html Removes an unused template snippet (no includes/usages found in repo search).

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.21%. Comparing base (2694822) to head (f6a6d47).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #870   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         384      384           
  Lines       23990    23990           
=======================================
  Hits        22123    22123           
  Misses       1867     1867           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chrismaddalena chrismaddalena merged commit 0735585 into master Apr 14, 2026
11 checks passed
@chrismaddalena chrismaddalena deleted the hotfix/code-quality-cleanup branch April 14, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants