Fallback options for object names + w coordinate fix#1
Merged
Conversation
Additionally adjust the CI job and fix some typos
weiznich
approved these changes
Jun 24, 2026
weiznich
left a comment
weiznich
left a comment
Member
There was a problem hiding this comment.
Looks mostly good to me, just some minor notes
42triangles
reviewed
Jun 24, 2026
Also added two new tests for these cases
This fallback will be used instead of "unnamed_object" and additionally we also use a counter to distinguish between multiple unnamed objects
SwishSwushPow
force-pushed
the
fallback_options_for_object_names
branch
from
June 24, 2026 10:29
75df903 to
17ae447
Compare
42triangles
approved these changes
Jun 24, 2026
weiznich
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we now enumerate all "unnamed_objects" to be able to distinguish them when parsing. Additionally, the user is able to provide a fallback base name, which will also be enumerated.
We also fixed an issue where vertices with an additional w scale component where not parsed correctly. Now it accepts w or rgb floats after the initial coordinates.