Skip to content

[Future] Fix issues in register donor page #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamessspanggg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Future] Fix issues in register donor page #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d4d4fb
Allow user to select account for google auth
jamessspanggg Jul 31, 2020
d830f8b
Change typo in register with google button
jamessspanggg Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/register/modules/RegisterDonor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ const RegisterDonor = () => {
onClick={handleGoogleRegister}
loading={googleLoading}
>
Sign in with Google
Register with Google
</SocialButton>
<Text align="center" spaceAfter="normal">
OR
Expand Down
4 changes: 4 additions & 0 deletions utils/api/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,10 @@ class AuthAPI {

async _googleAuth() {
const provider = new firebase.auth.GoogleAuthProvider();
// allow user to select own account
provider.setCustomParameters({
prompt: 'select_account',
Copy link
Copy Markdown
Contributor

@jinyingtan jinyingtan Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By setting this, means that when you login, you will always need to select an account?

Copy link
Copy Markdown
Contributor Author

@jamessspanggg jamessspanggg Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Copy Markdown
Contributor Author

@jamessspanggg jamessspanggg Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add on, when currently using desktop (safari, chrome), it always asks to select an account. But only for mobile, it automatically selects.

This addition causes the mobile to ask for selection before logging in as well.

});
return await firebaseAuth.signInWithPopup(provider);
}

Expand Down