Skip to content

Refactor/silent login#403

Open
kohchihao wants to merge 13 commits intomasterfrom
refactor/silentLogin
Open

Refactor/silent login#403
kohchihao wants to merge 13 commits intomasterfrom
refactor/silentLogin

Conversation

@kohchihao
Copy link
Copy Markdown
Contributor

@kohchihao kohchihao commented Dec 2, 2020 •
edited
Loading

In this PR,

  • Removed silentLogin
  • Refactor isAuthenticated with silentLogin code.

Tested

  • creating donor account

Still need to test more before merging PR

@kohchihao kohchihao changed the title [WIP] Refactor/silent login Refactor/silent login Dec 4, 2020
@kohchihao
Copy link
Copy Markdown
Contributor Author

kohchihao commented Dec 9, 2020

Remember to add this new ENV (FIRESTORE_EMULATOR_HOST="localhost:8080") to your .env file

jinyingtan
jinyingtan approved these changes Dec 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jinyingtan jinyingtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinyingtan jinyingtan jinyingtan approved these changes

@jamessspanggg jamessspanggg jamessspanggg approved these changes

Assignees

No one assigned

Labels

f.toMerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kohchihao @jinyingtan @jamessspanggg