Open
Conversation
…tion of ‘q’ shadows a member of ‘qglviewer::Quaternion’ [-Werror=shadow]
170 | Quaternion &operator*=(const Quaternion &q) {
| ~~~~~~~~~~~~~~~~~~^
/tmp/libQGLViewer/build/QGLViewer_autogen/QGLViewer/quaternion.h:309:9: note: shadowed declaration is here
309 | qreal q[4];
| ^
…declaration of ‘d’ shadows a member of ‘BSPNode’ [-Werror=shadow]
542 | void BSPNode::initEquation(const Polygone *P,double & a, double & b, double & c, double & d)
| ~~~~~~~~~^
/tmp/libQGLViewer/QGLViewer/VRender/BSPSortMethod.cpp:93:30: note: shadowed declaration is here
93 | double a,b,c,d;
| ^
…declaration of ‘c’ shadows a member of ‘BSPNode’ [-Werror=shadow]
542 | void BSPNode::initEquation(const Polygone *P,double & a, double & b, double & c, double & dd)
| ~~~~~~~~~^
/tmp/libQGLViewer/QGLViewer/VRender/BSPSortMethod.cpp:93:28: note: shadowed declaration is here
93 | double a,b,c,d;
| ^
…declaration of ‘b’ shadows a member of ‘BSPNode’ [-Werror=shadow]
542 | void BSPNode::initEquation(const Polygone *P,double & a, double & b, double & c, double & dd)
| ~~~~~~~~~^
/tmp/libQGLViewer/QGLViewer/VRender/BSPSortMethod.cpp:93:26: note: shadowed declaration is here
93 | double a,b,c,d;
| ^
…declaration of ‘a’ shadows a member of ‘BSPNode’ [-Werror=shadow]
542 | void BSPNode::initEquation(const Polygone *P,double & a, double & bb, double & cc, double & dd)
| ~~~~~~~~~^
/tmp/libQGLViewer/QGLViewer/VRender/BSPSortMethod.cpp:93:24: note: shadowed declaration is here
93 | double a,b,c,d;
| ^
… vrender::operator*(const NVector3&, const Vector3&)’ has not been declared within ‘vrender’ [-Werror]
41 | double vrender::operator*(const NVector3 &u,const Vector3 &v)
| ^~~~~~~
In file included from /tmp/libQGLViewer/QGLViewer/VRender/NVector3.cpp:1:
/tmp/libQGLViewer/QGLViewer/VRender/NVector3.h:45:19: note: only here as a ‘friend’
45 | friend double operator*(const NVector3 &u,const Vector3 &v);
| ^~~~~~~~
… vrender::operator*(const Vector3&, const NVector3&)’ has not been declared within ‘vrender’ [-Werror]
46 | double vrender::operator*(const Vector3 &u,const NVector3 &v)
| ^~~~~~~
In file included from /tmp/libQGLViewer/QGLViewer/VRender/NVector3.cpp:1:
/tmp/libQGLViewer/QGLViewer/VRender/NVector3.h:46:19: note: only here as a ‘friend’
46 | friend double operator*(const Vector3 &u,const NVector3 &v);
| ^~~~~~~~
…::ostream& vrender::operator<<(std::ostream&, const Feedback3DColor&)’ has not been declared within ‘vrender’ [-Werror]
121 | std::ostream& vrender::operator<<(std::ostream& o,const Feedback3DColor& f)
| ^~~~~~~
In file included from /tmp/libQGLViewer/QGLViewer/VRender/Primitive.cpp:3:
/tmp/libQGLViewer/QGLViewer/VRender/Primitive.h:61:38: note: only here as a ‘friend’
61 | friend std::ostream& operator<<(std::ostream&,const Feedback3DColor&) ;
| ^~~~~~~~
…::Vector2 vrender::operator-(const Vector2&)’ has not been declared within ‘vrender’ [-Werror]
50 | Vector2 vrender::operator- (const Vector2& u)
| ^~~~~~~
In file included from /tmp/libQGLViewer/QGLViewer/VRender/Vector2.cpp:1:
/tmp/libQGLViewer/QGLViewer/VRender/Vector2.h:73:40: note: only here as a ‘friend’
73 | friend Vector2 operator- (const Vector2&);
| ^~~~~~~~
…::Vector3 vrender::operator*(double, const Vector3&)’ has not been declared within ‘vrender’ [-Werror]
81 | Vector3 vrender::operator* (double r,const Vector3& u)
| ^~~~~~~
In file included from /tmp/libQGLViewer/QGLViewer/VRender/Vector3.cpp:2:
/tmp/libQGLViewer/QGLViewer/VRender/Vector3.h:114:40: note: only here as a ‘friend’
114 | friend Vector3 operator* (double,const Vector3&);
| ^~~~~~~~
…ostream& vrender::operator<<(std::ostream&, const Vector3&)’ has not been declared within ‘vrender’ [-Werror]
111 | std::ostream& vrender::operator<< (std::ostream& out,const Vector3& u)
| ^~~~~~~
/tmp/libQGLViewer/QGLViewer/VRender/Vector3.h:127:46: note: only here as a ‘friend’
127 | friend std::ostream& operator<< (std::ostream&,const Vector3&);
| ^~~~~~~~
…‘proj’ shadows a previous local [-Werror=shadow]
1038 | qreal proj = fabs(directions[0][i] * dir);
| ^~~~
/tmp/libQGLViewer/QGLViewer/frame.cpp:1009:9: note: shadowed declaration is here
1009 | qreal proj;
| ^~~~
…‘axis’ shadows a previous local [-Werror=shadow]
1046 | const Vec axis = cross(directions[0][index[0]], dir);
| ^~~~
/tmp/libQGLViewer/QGLViewer/frame.cpp:1025:15: note: shadowed declaration is here
1025 | const Vec axis = cross(directions[0][index[0]], directions[1][index[1]]);
| ^~~~
…‘angle’ shadows a previous local [-Werror=shadow]
1047 | qreal angle = asin(axis.norm());
| ^~~~~
/tmp/libQGLViewer/QGLViewer/frame.cpp:1026:11: note: shadowed declaration is here
1026 | qreal angle = asin(axis.norm());
| ^~~~~
…eclaration of ‘v1’ shadows a member of ‘qglviewer::KeyFrameInterpolator’ [-Werror=shadow]
340 | Vec v1 = 3.0 * diff - 2.0 * kf_[1]->tgP() - kf_[2]->tgP();
| ^~
In file included from /tmp/libQGLViewer/QGLViewer/camera.h:5,
from /tmp/libQGLViewer/QGLViewer/qglviewer.h:4,
from /tmp/libQGLViewer/QGLViewer/keyFrameInterpolator.cpp:2:
/tmp/libQGLViewer/QGLViewer/keyFrameInterpolator.h:354:7: note: shadowed declaration is here
354 | Vec v1, v2;
| ^~
…eclaration of ‘v2’ shadows a member of ‘qglviewer::KeyFrameInterpolator’ [-Werror=shadow]
341 | Vec v2 = -2.0 * diff + kf_[1]->tgP() + kf_[2]->tgP();
| ^~
In file included from /tmp/libQGLViewer/QGLViewer/camera.h:5,
from /tmp/libQGLViewer/QGLViewer/qglviewer.h:4,
from /tmp/libQGLViewer/QGLViewer/keyFrameInterpolator.cpp:2:
/tmp/libQGLViewer/QGLViewer/keyFrameInterpolator.h:354:11: note: shadowed declaration is here
354 | Vec v1, v2;
| ^~
… of ‘text’ shadows a previous local [-Werror=shadow]
1897 | QString text = mouseActionString(itmb.value().action);
| ^~~~
/tmp/libQGLViewer/QGLViewer/qglviewer.cpp:1846:11: note: shadowed declaration is here
1846 | QString text(
| ^~~~
… of ‘text’ shadows a previous local [-Werror=shadow]
1921 | QString text = mouseActionString(itw.value().action);
| ^~~~
/tmp/libQGLViewer/QGLViewer/qglviewer.cpp:1846:11: note: shadowed declaration is here
1846 | QString text(
| ^~~~
… of ‘q’ shadows a member of ‘qglviewer::Quaternion’ [-Werror=shadow]
227 | Quaternion q(element);
| ^
In file included from /tmp/libQGLViewer/QGLViewer/quaternion.cpp:1:
/tmp/libQGLViewer/QGLViewer/quaternion.h:309:9: note: shadowed declaration is here
309 | qreal q[4];
| ^
Contributor
Author
|
#75 (comment): seems there are cross dependencies between @GillesDebunne: cross dependency should be broken, not sure what is better as I don't know how code was designed. My understanding is that |
…be explicitly initialized in the copy constructor [-Werror=extra] 21 | NVector3::NVector3(const NVector3& u)
… ‘CameraViewer’ [-Werror=shadow]
16 | const float c = cos(angle);
| ^
Contributor
Author
|
The last warnings are Qt deprecation which fix may depend on version Qt5/6... |
GillesDebunne
force-pushed
the
main
branch
3 times, most recently
from
9461267 to
f12d2f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile with warning as error.
Note: gave up on Qt deprecated declarations for a start...