Skip to content

feat: add glassmorphism effect to navbar #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mehul-m-prajapati merged 2 commits into from
May 23, 2026
Merged

feat: add glassmorphism effect to navbar #330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79e21cc
feat: add glassmorphism effect to navbar
Kartikey-Pathak May 19, 2026
47f400b
Merge branch 'main' into feat/glass-navbar
mehul-m-prajapati May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function App() {
const isFullscreen = FULLSCREEN_ROUTES.includes(location.pathname);

return (
<div className="relative flex flex-col min-h-screen">
<div className="relative bg-[#1F2937] flex flex-col min-h-screen">

@coderabbitai coderabbitai Bot May 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Avoid hardcoding a dark root background in a theme-aware layout.

Line 15 sets a fixed dark color (bg-[#1F2937]), which can make the light theme look tinted behind translucent UI (notably the glass navbar). Use light/dark classes instead.

Proposed fix 
-      <div className="relative bg-[`#1F2937`] flex flex-col min-h-screen">
+      <div className="relative bg-gray-50 dark:bg-gray-900 flex flex-col min-h-screen">
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<div className="relative bg-[#1F2937] flex flex-col min-h-screen">
<div className="relative bg-gray-50 dark:bg-gray-900 flex flex-col min-h-screen">
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/App.tsx` at line 15, The root layout hardcodes a dark background via the
div className "bg-[`#1F2937`]" in App (the root JSX element), which breaks
theme-awareness; replace that hardcoded color with theme-aware utility classes
(e.g., separate light and dark classes such as bg-white and dark:bg-... or your
design-system surface classes) so the root background follows the active theme
and doesn't tint translucent components like the glass navbar; update the
className on the same root div in App.tsx (where "relative bg-[`#1F2937`] flex
flex-col min-h-screen" appears) to use appropriate light/dark classes and remove
the hardcoded hex.

{!isFullscreen && <ScrollProgressBar />}

{!isFullscreen && <Navbar />}
Expand Down
Loading