Add BlackOilFluidState::createFluidState static factory method#2
Draft
Add BlackOilFluidState::createFluidState static factory method#2
Conversation
Co-authored-by: GitPaean <6847941+GitPaean@users.noreply.github.com>
Co-authored-by: GitPaean <6847941+GitPaean@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add function to create fluid state in BlackoilFluidState
Add BlackOilFluidState::createFluidState static factory method
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createFluidStatelogic in opm-simulators required passing many TypeTag boolean flags explicitly. Moving it intoBlackOilFluidStateas a static factory eliminates that redundancy — the class template parameters already encode all feature flags.Changes
BlackOilFluidState.hpp: AddedcreateFluidState<ValueType>static method declaration; added<string_view>and<vector>includes.BlackOilFluidState_impl.hpp(new): Out-of-class implementation included at the bottom of the header. Three-step algorithm:Opm::getValue()in error messages so formatting is safe with ADEvaluationtypesstatic_assert(fluidSystemIsStatic)guards against use with non-static fluid systemstest_blackoilfluidstate.cpp: Compile-timestatic_assertverifying the return type and signature ofcreateFluidState<Evaluation>.Usage
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.