Add a logger delegate class for logging.

[darthsteven]

I'd like to be able to swap out the logger for something more exciting that just the watchdog, and I have the need to log success messages, so I figured that a nice way to supply this would be via a logger delegate class that can be easily swapped out.

[amitaibu]

@darthsteven can you share a bit more about your use case - how is Message + Message notify serving you better?

[darthsteven]

So I have a need to audit the sent messages and keep a history of what was sent, to whom and success/failure.

The stack doesn't seem to support that sort of auditing, unless I'm mistaken. I will provide another module that will swap out the default logger delegate class so that sent messages are funneled into my audit trail.

[amitaibu]

I believe this PR isn't needed, as you can already implement what you want (if I got it wrong feel free to re-open):

So I have a need to audit the sent messages and keep a history of what was sent, to whom

That you can already do -- see the example module

and success/failure.

Since it's using drupal_mail() the watchdog is already taken care of. You could extend the functionality, as the return value of the email plugin is sending result.

[darthsteven]

Well, I am trying to do the second part there, and extend the logging beyond a simple watchdog on fail. I don't want to have to override all methods on all the classes we can configure for sending, I just want to log in a single place, and have any class that we configure for sending additionally have it's results logged in this way.

[darthsteven]

So there's a example (advanced) logging module here:
https://www.drupal.org/project/message_notify_logger

[amitaibu]

Ok, I better understand now -- you want to pipe all sent messages to be logged in one single place. Re-opening.

[amitaibu]

Missing PHPdocs.

[amitaibu]

I had only some minor comments. It would be great to add a simpleTest that verify a log using a dummy logger that will for example, log to a variable -- so it could be tested easily.

[darthsteven]

I don't have time to do this right now, but it's on the list, and I'll get back to it, but if someone else wants to pick it up and run with it, feel free!

[amitaibu]

Experience shows no one ever picks the tests ;)