add dataset to bulk downloads request and response models#67
Open
lykmapipo wants to merge 2 commits into
Open
Conversation
…eports This: - Add `dataset` field to `BulkReportItem` to track the `dataset` used to generate the bulk report - Add `dataset` field to `BulkReportListParams` to support filtering bulk reports by a specific `dataset` - Update `BulkDownloadResource.get_all_bulk_reports()` public method to accept the optional `dataset` filter parameter
lykmapipo
requested review from
aperdizs,
giselamo,
rrequero,
tomaslink and
yaaNuamahGFW
yaaNuamahGFW
left a comment
yaaNuamahGFW
left a comment
Collaborator
There was a problem hiding this comment.
One wiring issue with the new dataset filter.
| offset: Optional[int] = None, | ||
| sort: Optional[str] = None, | ||
| status: Optional[Union[BulkReportStatus, str]] = None, | ||
| dataset: Optional[str] = None, |
Collaborator
There was a problem hiding this comment.
dataset is added to the public method and request params model, but it is not passed into _prepare_get_all_bulk_report_params(), so the filter is ignored. Can we pass dataset=dataset into the helper and include it in the helper’s _request_params dict?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
datasetfield toBulkReportItemto track thedatasetused to generate the bulk reportdatasetfield toBulkReportListParamsto support filtering bulk reports by a specificdatasetBulkDownloadResource.get_all_bulk_reports()public method to accept the optionaldatasetfilter parameter