Refactor and simplify FixedString implementation#13
Open
Joshix-1 wants to merge 12 commits intoGnomedDev:masterfrom
Open
Refactor and simplify FixedString implementation#13Joshix-1 wants to merge 12 commits intoGnomedDev:masterfrom
Joshix-1 wants to merge 12 commits intoGnomedDev:masterfrom
Conversation
GnomedDev
reviewed
Sep 19, 2025
Owner
GnomedDev
left a comment
GnomedDev
left a comment
There was a problem hiding this comment.
Hey, can you please split this up into atomic commits and explain what your goals are with this refactor/simplify since it has added 80 LOC when I would expect drying code out to reduce LOC.
I don't have much bandwidth to be doing OSS work rn and I don't have the energy to review this PR as it is.
Joshix-1
force-pushed
the
refactor-breaking-change
branch
from
4573cbd to
4012eb6
Compare
Contributor
Author
|
Tried to improve the commits a bit, but no worries. This isn't really important.
I think those are because of added tests and added trait implementations.
Not sure myself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just wanted to implement
TryFrom<Cow<str>>and then tried to DRY out the code.While doing this I noticed #12 which I extracted into it's own pr, as it's less controversial and not a breaking change.